From e02ec88b1c6f02a7673f19f21afde51fbe460ae3 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Fri, 9 Feb 2024 19:23:47 -0600 Subject: [PATCH] Honda Civic & CR-V Bosch: allow fingerprinting without comma power (#31259) * Honda Civic Bosch: remove OBD-reliant ECUs from fingerprinting * eligible to fingerprint with these responses now * same for CRV bosch * add back all FW to test fingerprinting diff on data * set these ECUs as non essential instead * comment * compare old fingerprinting with non essential fingerprinting * clean up * cmt --- selfdrive/car/honda/values.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/selfdrive/car/honda/values.py b/selfdrive/car/honda/values.py index 2878076de..300c21d2f 100644 --- a/selfdrive/car/honda/values.py +++ b/selfdrive/car/honda/values.py @@ -195,10 +195,19 @@ FW_QUERY_CONFIG = FwQueryConfig( [StdQueries.UDS_VERSION_REQUEST], [StdQueries.UDS_VERSION_RESPONSE], bus=1, - logging=True, obd_multiplexing=False, ), ], + # We lose these ECUs without the comma power on these cars. + # Note that we still attempt to match with them when they are present + non_essential_ecus={ + Ecu.programmedFuelInjection: [CAR.CIVIC_BOSCH, CAR.CRV_5G], + Ecu.transmission: [CAR.CIVIC_BOSCH, CAR.CRV_5G], + Ecu.vsa: [CAR.CIVIC_BOSCH, CAR.CRV_5G], + Ecu.combinationMeter: [CAR.CIVIC_BOSCH, CAR.CRV_5G], + Ecu.gateway: [CAR.CIVIC_BOSCH, CAR.CRV_5G], + Ecu.electricBrakeBooster: [CAR.CIVIC_BOSCH, CAR.CRV_5G], + }, extra_ecus=[ # The only other ECU on PT bus accessible by camera on radarless Civic (Ecu.unknown, 0x18DAB3F1, None),