soundd: misc cleanup + tests (#22796)
* pass AudibleAlert to setAlert
* apply reviews
* remove trailing underscore
* add current_alert_type
* common function get_alert
* same freq as ui
* small cleanup
* setvolumne on change
* static Alert::get
* test_sounds
* remove old test files
* loop twice
* assert loopsRemaining
* assert stop
* init to min_volumne
* Revert "remove old test files"
This reverts commit 12e8bfefae1ae7f8649d3eda1e4126ff8eb1fe17.
* move to ui/soundd
* move test to tests/test_sound.cc
* remove old tests
* cleanup
* lower volume
* Revert "remove old tests"
This reverts commit e6bb12abfa3d5cd0aa8986d2b8da0b1edc7ea31b.
* return Alert
* cleanup
* remove #include <optional>
* cleanup .gitignore
* revert to std::optional
* Revert "revert to std::optional"
This reverts commit a66291c51f3a846652837cc4a43d5d60dd81896b.
* cleanup
* remove volume check
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
|
Dean Lee
Adeeb Shihadeh
Greg Hogan
George Hotz