framereader.cc: remove nv12toyuv_buffer (#24991)

remove nv12toyuv_buffer
old-commit-hash: e0cd3bf5fc

tools/replay/framereader.cc

@@ -117,8 +117,6 @@ bool FrameReader::load(const std::byte *data, size_t size, bool no_hw_decoder, s
   if (has_hw_decoder && !no_hw_decoder) {
     if (!initHardwareDecoder(HW_DEVICE_TYPE)) {
       rWarning("No device with hardware decoder found. fallback to CPU decoding.");
-    } else {
-      nv12toyuv_buffer.resize(getYUVSize());
     }
   }
 
@@ -227,17 +225,16 @@ AVFrame *FrameReader::decodeFrame(AVPacket *pkt) {
 }
 
 bool FrameReader::copyBuffers(AVFrame *f, uint8_t *yuv) {
-  if (hw_pix_fmt == HW_PIX_FMT) {
+  assert(f != nullptr && yuv != nullptr);
-    uint8_t *y = yuv ? yuv : nv12toyuv_buffer.data();
+  uint8_t *y = yuv;
   uint8_t *uv = y + width * height;
+  if (hw_pix_fmt == HW_PIX_FMT) {
     for (int i = 0; i < height/2; i++) {
       memcpy(y + (i*2 + 0)*width, f->data[0] + (i*2 + 0)*f->linesize[0], width);
       memcpy(y + (i*2 + 1)*width, f->data[0] + (i*2 + 1)*f->linesize[0], width);
       memcpy(uv + i*width, f->data[1] + i*f->linesize[1], width);
     }
   } else {
-    uint8_t *y = yuv ? yuv : nv12toyuv_buffer.data();
-    uint8_t *uv = y + width * height;
     libyuv::I420ToNV12(f->data[0], f->linesize[0],
                        f->data[1], f->linesize[1],
                        f->data[2], f->linesize[2],

tools/replay/framereader.h

@@ -46,7 +46,6 @@ private:
 
   AVPixelFormat hw_pix_fmt = AV_PIX_FMT_NONE;
   AVBufferRef *hw_device_ctx = nullptr;
-  std::vector<uint8_t> nv12toyuv_buffer;
   int prev_idx = -1;
   inline static std::atomic<bool> has_hw_decoder = true;
 };