From 1b8be22a4c83c2d14eab210aafb8ccf3e6252138 Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Wed, 8 Dec 2021 02:41:41 +0800
Subject: [PATCH] DevicePanel: fix dangling reference to params (#23154)

old-commit-hash: 6e25ae9798bbdad55259333194b6f3c33679c475
---
 selfdrive/ui/qt/offroad/settings.cc | 2 --
 selfdrive/ui/qt/offroad/settings.h  | 3 +++
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/selfdrive/ui/qt/offroad/settings.cc b/selfdrive/ui/qt/offroad/settings.cc
index 487ba5624..eee4dab05 100644
--- a/selfdrive/ui/qt/offroad/settings.cc
+++ b/selfdrive/ui/qt/offroad/settings.cc
@@ -105,8 +105,6 @@ TogglesPanel::TogglesPanel(SettingsWindow *parent) : ListWidget(parent) {
 }
 
 DevicePanel::DevicePanel(SettingsWindow *parent) : ListWidget(parent) {
-  Params params = Params();
-
   setSpacing(50);
   addItem(new LabelControl("Dongle ID", getDongleId().value_or("N/A")));
   addItem(new LabelControl("Serial", params.get("HardwareSerial").c_str()));
diff --git a/selfdrive/ui/qt/offroad/settings.h b/selfdrive/ui/qt/offroad/settings.h
index fe8818066..7fc5a8581 100644
--- a/selfdrive/ui/qt/offroad/settings.h
+++ b/selfdrive/ui/qt/offroad/settings.h
@@ -47,6 +47,9 @@ private slots:
   void poweroff();
   void reboot();
   void updateCalibDescription();
+
+private:
+  Params params;
 };
 
 class TogglesPanel : public ListWidget {