Fix RequestRepeater caching (#21693)

* Fix RequestRepeater caching

* cleanup

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: ca51b3865f
vw-mqb-aeb
Adeeb Shihadeh 4 years ago committed by GitHub
parent 02f1895b7d
commit 4720bafdb3
  1. 8
      selfdrive/ui/qt/request_repeater.cc

@ -15,7 +15,7 @@ RequestRepeater::RequestRepeater(QObject *parent, const QString &requestURL, con
if (!cacheKey.isEmpty()) { if (!cacheKey.isEmpty()) {
prevResp = QString::fromStdString(params.get(cacheKey.toStdString())); prevResp = QString::fromStdString(params.get(cacheKey.toStdString()));
if (!prevResp.isEmpty()) { if (!prevResp.isEmpty()) {
QTimer::singleShot(0, [=]() { emit receivedResponse(prevResp); }); QTimer::singleShot(500, [=]() { emit receivedResponse(prevResp); });
} }
QObject::connect(this, &HttpRequest::receivedResponse, [=](const QString &resp) { QObject::connect(this, &HttpRequest::receivedResponse, [=](const QString &resp) {
if (resp != prevResp) { if (resp != prevResp) {
@ -23,11 +23,5 @@ RequestRepeater::RequestRepeater(QObject *parent, const QString &requestURL, con
prevResp = resp; prevResp = resp;
} }
}); });
QObject::connect(this, &HttpRequest::failedResponse, [=](const QString &err) {
if (!prevResp.isEmpty()) {
params.remove(cacheKey.toStdString());
prevResp = "";
}
});
} }
} }

Loading…
Cancel
Save