OnroadAlerts: construct QPainter only when needed (#21260)

old-commit-hash: d07b45f50a
4 years ago · a760fcfbde
parent 33a3bb5fc9
commit a760fcfbde
1 changed files with 2 additions and 2 deletions
--- a/selfdrive/ui/qt/onroad.cc
+++ b/selfdrive/ui/qt/onroad.cc
@ -148,8 +148,6 @@ void OnroadAlerts::stopSounds() {
 }

 void OnroadAlerts::paintEvent(QPaintEvent *event) {
-  QPainter p(this);
-
  if (alert_size == cereal::ControlsState::AlertSize::NONE) {
    return;
  }
@ -161,6 +159,8 @@ void OnroadAlerts::paintEvent(QPaintEvent *event) {
  int h = alert_sizes[alert_size];
  QRect r = QRect(0, height() - h, width(), h);

+  QPainter p(this);
+
  // draw background + gradient
  p.setPen(Qt::NoPen);
  p.setCompositionMode(QPainter::CompositionMode_SourceOver);