From bf39eb50ade2bc4bf61fbe7b80cdbd36c49551b1 Mon Sep 17 00:00:00 2001 From: grekiki Date: Fri, 22 Jan 2021 14:36:42 +0100 Subject: [PATCH] qt ui: don't refresh wifi widget if it is not visible (#19876) Co-authored-by: Comma Device old-commit-hash: 621a6c16a462fabc4a0696695a1797f8bf5db093 --- selfdrive/ui/qt/offroad/wifi.cc | 9 ++++----- selfdrive/ui/qt/offroad/wifi.hpp | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/selfdrive/ui/qt/offroad/wifi.cc b/selfdrive/ui/qt/offroad/wifi.cc index dac77f2f7..741f0f0e0 100644 --- a/selfdrive/ui/qt/offroad/wifi.cc +++ b/selfdrive/ui/qt/offroad/wifi.cc @@ -100,7 +100,11 @@ Networking::Networking(QWidget* parent) : QWidget(parent){ } void Networking::refresh(){ + if(!this->isVisible()){ + return; + } wifiWidget->refresh(); + an->refresh(); } void Networking::connectToNetwork(Network n) { @@ -255,11 +259,6 @@ AdvancedNetworking::AdvancedNetworking(QWidget* parent, WifiManager* wifi): QWid s->addWidget(settingsWidget); s->setCurrentIndex(1); setLayout(s); - - // Update network status - QTimer* timer = new QTimer(this); - QObject::connect(timer, SIGNAL(timeout()), this, SLOT(refresh())); - timer->start(5000); } void AdvancedNetworking::refresh(){ diff --git a/selfdrive/ui/qt/offroad/wifi.hpp b/selfdrive/ui/qt/offroad/wifi.hpp index f2ef5298f..05fad4c30 100644 --- a/selfdrive/ui/qt/offroad/wifi.hpp +++ b/selfdrive/ui/qt/offroad/wifi.hpp @@ -58,7 +58,7 @@ signals: void closeKeyboard(); void backPress(); -private slots: +public slots: void receiveText(QString text); void abortTextInput(); void toggleTethering(int enable);