From c197b3f52c6c3698a0c917fe24caf4766b1f96a8 Mon Sep 17 00:00:00 2001
From: Justin Newberry <justin@comma.ai>
Date: Thu, 21 Mar 2024 16:00:30 -0400
Subject: [PATCH] add helper for creating build_metadata from a dict (#31958)

helper
---
 system/version.py | 34 ++++++++++++++++++----------------
 1 file changed, 18 insertions(+), 16 deletions(-)

diff --git a/system/version.py b/system/version.py
index f370beb4a..ab8082dce 100755
--- a/system/version.py
+++ b/system/version.py
@@ -104,28 +104,30 @@ class BuildMetadata:
     return self.channel in RELEASE_BRANCHES
 
 
+def build_metadata_from_dict(build_metadata: dict) -> BuildMetadata:
+  channel = build_metadata.get("channel", "unknown")
+  openpilot_metadata = build_metadata.get("openpilot", {})
+  version = openpilot_metadata.get("version", "unknown")
+  release_notes = openpilot_metadata.get("release_notes", "unknown")
+  git_commit = openpilot_metadata.get("git_commit", "unknown")
+  git_origin = openpilot_metadata.get("git_origin", "unknown")
+  git_commit_date = openpilot_metadata.get("git_commit_date", "unknown")
+  return BuildMetadata(channel,
+            OpenpilotMetadata(
+              version=version,
+              release_notes=release_notes,
+              git_commit=git_commit,
+              git_origin=git_origin,
+              git_commit_date=git_commit_date,
+              is_dirty=False))
+
 
 def get_build_metadata(path: str = BASEDIR) -> BuildMetadata:
   build_metadata_path = pathlib.Path(path) / BUILD_METADATA_FILENAME
 
   if build_metadata_path.exists():
     build_metadata = json.loads(build_metadata_path.read_text())
-    openpilot_metadata = build_metadata.get("openpilot", {})
-
-    channel = build_metadata.get("channel", "unknown")
-    version = openpilot_metadata.get("version", "unknown")
-    release_notes = openpilot_metadata.get("release_notes", "unknown")
-    git_commit = openpilot_metadata.get("git_commit", "unknown")
-    git_origin = openpilot_metadata.get("git_origin", "unknown")
-    git_commit_date = openpilot_metadata.get("git_commit_date", "unknown")
-    return BuildMetadata(channel,
-              OpenpilotMetadata(
-                version=version,
-                release_notes=release_notes,
-                git_commit=git_commit,
-                git_origin=git_origin,
-                git_commit_date=git_commit_date,
-                is_dirty=False))
+    return build_metadata_from_dict(build_metadata)
 
   git_folder = pathlib.Path(path) / ".git"