From da38aed48300ca1db0a1032c12c26b0268ebb03c Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Thu, 17 Aug 2023 01:02:59 -0700 Subject: [PATCH] map: set destination marker visibility once (#29444) set visibility once --- selfdrive/ui/qt/maps/map.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/selfdrive/ui/qt/maps/map.cc b/selfdrive/ui/qt/maps/map.cc index 7487df8bc..e7e8f757b 100644 --- a/selfdrive/ui/qt/maps/map.cc +++ b/selfdrive/ui/qt/maps/map.cc @@ -377,8 +377,6 @@ void MapWindow::offroadTransition(bool offroad) { } void MapWindow::updateDestinationMarker() { - m_map->setPaintProperty("pinLayer", "visibility", "none"); - auto nav_dest = coordinate_from_param("NavDestination"); if (nav_dest.has_value()) { auto point = coordinate_to_collection(*nav_dest); @@ -388,5 +386,7 @@ void MapWindow::updateDestinationMarker() { pinSource["data"] = QVariant::fromValue(feature); m_map->updateSource("pinSource", pinSource); m_map->setPaintProperty("pinLayer", "visibility", "visible"); + } else { + m_map->setPaintProperty("pinLayer", "visibility", "none"); } }