remove lead car display for now

mqb-long
Jason Young 3 years ago
parent 94a6e8d4f9
commit e54d978c83
  1. 3
      selfdrive/car/volkswagen/carcontroller.py
  2. 5
      selfdrive/car/volkswagen/carstate.py
  3. 5
      selfdrive/car/volkswagen/mqbcan.py
  4. 5
      selfdrive/car/volkswagen/pqcan.py

@ -89,8 +89,7 @@ class CarController:
if self.frame % self.CCP.ACC_HUD_STEP == 0 and self.CP.openpilotLongitudinalControl: if self.frame % self.CCP.ACC_HUD_STEP == 0 and self.CP.openpilotLongitudinalControl:
acc_hud_status = self.CCS.acc_hud_status_value(CS.out.cruiseState.available, CS.out.accFaulted, CC.longActive) acc_hud_status = self.CCS.acc_hud_status_value(CS.out.cruiseState.available, CS.out.accFaulted, CC.longActive)
set_speed = hud_control.setSpeed * CV.MS_TO_KPH # FIXME: follow the recent displayed-speed updates, also use mph_kmh toggle to fix display rounding problem? set_speed = hud_control.setSpeed * CV.MS_TO_KPH # FIXME: follow the recent displayed-speed updates, also use mph_kmh toggle to fix display rounding problem?
can_sends.extend(self.CCS.create_acc_hud_control(self.packer_pt, CANBUS.pt, acc_hud_status, set_speed, can_sends.extend(self.CCS.create_acc_hud_control(self.packer_pt, CANBUS.pt, acc_hud_status, set_speed))
hud_control.leadVisible))
# **** Stock ACC Button Controls **************************************** # # **** Stock ACC Button Controls **************************************** #

@ -139,9 +139,6 @@ class CarState(CarStateBase):
# Additional safety checks performed in CarInterface. # Additional safety checks performed in CarInterface.
ret.espDisabled = pt_cp.vl["ESP_21"]["ESP_Tastung_passiv"] != 0 ret.espDisabled = pt_cp.vl["ESP_21"]["ESP_Tastung_passiv"] != 0
# Update misc car configuration/equipment info
self.digital_cluster_installed = bool(pt_cp.vl["Kombi_03"]["KBI_Variante"])
return ret return ret
def update_pq(self, pt_cp, cam_cp, ext_cp, trans_type): def update_pq(self, pt_cp, cam_cp, ext_cp, trans_type):
@ -279,7 +276,6 @@ class CarState(CarStateBase):
("ESP_Tastung_passiv", "ESP_21"), # Stability control disabled ("ESP_Tastung_passiv", "ESP_21"), # Stability control disabled
("ESP_Haltebestaetigung", "ESP_21"), # ESP hold confirmation ("ESP_Haltebestaetigung", "ESP_21"), # ESP hold confirmation
("KBI_Handbremse", "Kombi_01"), # Manual handbrake applied ("KBI_Handbremse", "Kombi_01"), # Manual handbrake applied
("KBI_Variante", "Kombi_03"), # Digital/full-screen instrument cluster installed
("TSK_Status", "TSK_06"), # ACC engagement status from drivetrain coordinator ("TSK_Status", "TSK_06"), # ACC engagement status from drivetrain coordinator
("GRA_Hauptschalter", "GRA_ACC_01"), # ACC button, on/off ("GRA_Hauptschalter", "GRA_ACC_01"), # ACC button, on/off
("GRA_Abbrechen", "GRA_ACC_01"), # ACC button, cancel ("GRA_Abbrechen", "GRA_ACC_01"), # ACC button, cancel
@ -310,7 +306,6 @@ class CarState(CarStateBase):
("Airbag_02", 5), # From J234 Airbag control module ("Airbag_02", 5), # From J234 Airbag control module
("Kombi_01", 2), # From J285 Instrument cluster ("Kombi_01", 2), # From J285 Instrument cluster
("Blinkmodi_02", 1), # From J519 BCM (sent at 1Hz when no lights active, 50Hz when active) ("Blinkmodi_02", 1), # From J519 BCM (sent at 1Hz when no lights active, 50Hz when active)
("Kombi_03", 1), # From J285 instrument cluster
] ]
if CP.transmissionType == TransmissionType.automatic: if CP.transmissionType == TransmissionType.automatic:

@ -104,7 +104,7 @@ def create_acc_accel_control(packer, bus, enabled, acc_status, accel, stopping,
return commands return commands
def create_acc_hud_control(packer, bus, acc_hud_status, set_speed, lead_visible): def create_acc_hud_control(packer, bus, acc_hud_status, set_speed):
commands = [] commands = []
acc_02_values = { acc_02_values = {
@ -112,9 +112,8 @@ def create_acc_hud_control(packer, bus, acc_hud_status, set_speed, lead_visible)
"ACC_Wunschgeschw": set_speed if set_speed < 250 else 327.36, "ACC_Wunschgeschw": set_speed if set_speed < 250 else 327.36,
"ACC_Gesetzte_Zeitluecke": 3, "ACC_Gesetzte_Zeitluecke": 3,
"ACC_Display_Prio": 3, "ACC_Display_Prio": 3,
"ACC_Abstandsindex": 512 if lead_visible else 0, # FIXME: will break analog clusters during refactor
} }
# TODO: ACC_Abstandsindex for lead car distance, must determine analog vs digital cluster for scaling
commands.append(packer.make_can_msg("ACC_02", bus, acc_02_values)) commands.append(packer.make_can_msg("ACC_02", bus, acc_02_values))
return commands return commands

@ -72,13 +72,12 @@ def create_acc_accel_control(packer, bus, enabled, acc_status, accel, stopping,
packer.make_can_msg("ACC_System", bus, values) packer.make_can_msg("ACC_System", bus, values)
def create_acc_hud_control(packer, bus, acc_hud_status, set_speed, lead_visible): def create_acc_hud_control(packer, bus, acc_hud_status, set_speed):
values = { values = {
"ACA_StaACC": acc_hud_status, "ACA_StaACC": acc_hud_status,
"ACA_Zeitluecke": 2, "ACA_Zeitluecke": 2,
"ACA_V_Wunsch": set_speed, "ACA_V_Wunsch": set_speed,
"ACA_gemZeitl": 8 if lead_visible else 0,
} }
# TODO: ACA_ID_StaACC, ACA_AnzDisplay, ACA_kmh_mph, ACA_PrioDisp, ACA_Aend_Zeitluecke # TODO: ACA_gemZeitl, ACA_ID_StaACC, ACA_AnzDisplay, ACA_kmh_mph, ACA_PrioDisp, ACA_Aend_Zeitluecke
return packer.make_can_msg("ACC_GRA_Anziege", bus, values) return packer.make_can_msg("ACC_GRA_Anziege", bus, values)

Loading…
Cancel
Save