5ed587ebef
controls: block resume if cruise not previously engaged ( #25402 )
...
* see if this works at all
* can revert this
* think adding a no entry conditionally is nicer
* then we can revert this
* 0 makes more sense
* Revert "0 makes more sense"
This reverts commit efc89e8a2389ef58fbc0cec0a2872d24db524867.
* gm CC uses > 70
* bump cereal
* comment
* test on Honda
* whoops
* works
* add exception with todo
* moved button enable events to controlsd
* get rid of that
get rid of that
* different values for now
* car interfaces add enable event, controlsd can block it
* Regen and update refs
* delete if not set
* One place
one place
* regen routes are uninitialized first few frames
* Trim start of segment so it's like original segment
* stash
* regen
* not working
* clean up
* more cleanup
* revert
* bump ceral
* actually check resume button
* whoops
* pcmCruise cars don't use setSpeed, so we're good
* engage correctly in sim
* Update ref_commit
* Update refs
3 years ago
87ca42e993
process replay: initialize controlsState with original route ( #25461 )
...
* push
* do process replay
* commit
* update refs
* clean up
* clean up controlsd
* clean up controlsd
* Add assert
* debubuggier param name
* can be peristent
* Revert "can be peristent"
This reverts commit 6e6d3f6423c26a202623cef728e038259e9e46cd.
* Update selfdrive/test/process_replay/process_replay.py
3 years ago
24645c92da
Use steeringAngleDeg for angle control saturation warnings ( #25404 )
...
* use steeringAngleDeg for angle control cars
* update refs
3 years ago
e77dc1ab44
Lateral Acceleration Error alert (Sensor Invalid) ( #25291 )
...
* sensor flag in paramsd
* increase lateral acc err alert threshold
* add invalid sensor alert from paramsd
* update ref, bool before adding to msg
* account for sign difference in locationd and paramsd
* revert ref
3 years ago
d462a08056
remove CS.steeringRateLimited ( #25251 )
...
* remove CS.steeringRateLimited
* bump cereal
* update refs
3 years ago
f300a8df2b
use v_cruise_cluster_kph for hudControl.setSpeed ( #25245 )
3 years ago
c3e95d5e19
prereq for matching speeds shown on cars dash ( #25222 )
...
* prereq for matching speeds shown on cars dash
* also handle fallback in the ui for replay
* update translations
* update ref
3 years ago
505bbce29d
controlsd: handle radar missing + cleanup system error handling ( #25179 )
...
* controlsd: handle radar missing + cleanup system erorr handling
* fix carla
* update refs
3 years ago
2ae52e9b22
process replay: ensure enabled for significant amount of time ( #25121 )
...
* process replay: ensure enabled for significant amount of time
* update refs
* 10s is reasonable
3 years ago
be7f704168
Fix new steer saturated warning with joystick mode ( #25113 )
...
Fix steer sat warning with joystick mode
3 years ago
fd2de54172
Stock longitudinal: spam resume button when lead starts moving ( #24873 )
...
* always log leads, we hide them in ui
* only spam resume when future is > vEgoStarting
* do rest but vw
* vw
* remove comments
* rename to resume
* maintain original button msg rate
* mazda: ensure no resume if cancelling
* same for non-HDA2
* Always run planner if not opLong
* try 0.2
* 0.1 should be pretty safe
* add test for resuming
* fix test
* stricter test, speeds[-1] is 0.14 when starting here
* no walrus
* fixup mazda cc
* remove extra import
3 years ago
d4cc13c88a
controlsd: avoid lag on first iteration due to get_short_branch ( #25031 )
...
* controlsd: avoid lag on first iteration due to get_short_branch
* always cache
3 years ago
0c95493dc0
Torque control: max torque warning ( #25018 )
...
* New steer torque warning
* typo
3 years ago
cdc7a6dbea
enable laikad ( #25013 )
...
* enable laikad
* increase logprint for onroad test
3 years ago
7c826b4fa1
add param to override carParams.dashcamOnly ( #24857 )
...
* add param to override carParams.dashcamOnly
* little cleaner
3 years ago
0fce5d9045
Move a bunch of stuff to system/ part 3 ( #24829 )
...
* move swaglog.py
* timezoned
* logmessaged
* version.py
* fix linter
3 years ago
1139fe507b
Move selfdrive/hardware/ to system/ ( #24725 )
...
* move hardware to system/
* fix mypy
3 years ago
f49a9c9fd2
less TICI when not needed ( #24698 )
...
* less TICI when not needed
* fix process replay
* move reading voltages into hw abstraction layer
* Update selfdrive/hardware/tici/hardware.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/hardware/hw.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/hardware/base.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* rename init function
* Update selfdrive/athena/athenad.py
Co-authored-by: Robbe Derks <robbe.derks@gmail.com>
* Update selfdrive/boardd/boardd.cc
* Apply suggestions from code review
* Update selfdrive/thermald/thermald.py
* update ref
* fix alert width if all cameras are bad
* add ecam to test_loggerd
* bump cereal
* bump cereal
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Robbe Derks <robbe.derks@gmail.com>
3 years ago
d928972150
Rerevert torque control ( #24649 )
...
* Revert "Revert torque control (#24565 )"
This reverts commit 9f8b03753d
3 years ago
71901c94db
controlsd: ensure all system malfunction events have the right types ( #24635 )
3 years ago
d3d210c183
controls: pressing set while gas pressed resets to vEgo ( #24100 )
...
* set while gas pressed to resume
* better order
* what was I thinking?
* Update selfdrive/controls/lib/drive_helpers.py
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
* Update selfdrive/controls/lib/drive_helpers.py
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
* only if under set speed
* some clean up and ciel the v_cruise_kph
* clean up
* actually floor
* Should be cruise min
* On phone, will clean up
* Think no floor is fine
* clean up and catch setCruise
* update comment and just always do rounding and clipping
update comment
* flip order
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
3 years ago
9f8b03753d
Revert torque control ( #24565 )
...
* torque reversal start
* Fix carmodel tests
* Update ref
* update ref
* Elif is better than if
3 years ago
b1858df00e
improved alert verbosity ( #24434 )
...
* improved alert verbosity
* better testing script
* better description
* speed diff
* touch ups
* fix that
3 years ago
6518ecca8f
Add desired curvature to controlsState ( #24510 )
...
* Add desired_curvature to controlsState
* clean up
* bump
* bump
* update refs from GitHub!
Co-authored-by: Jason Shuler <jshuler@gmail.com>
4 years ago
17e33978cd
Mypy fixes for --check-untyped-defs ( #24372 )
...
more type fixes
4 years ago
1bc6f2fa7d
increase cruiseMismatch threshold ( #24428 )
4 years ago
be748c0d6a
controlsd: better alert precedence for system malfunctions ( #24366 )
...
* controlsd: better alert precedence for system malfunctions
* down to 20
* move that
* check can flags
* update refs
* update refs
4 years ago
3abbe827de
controlsd: add lagging alert ( #24360 )
...
* controlsd: add lagging alert
* move those
* just this for now
* no camera malfunction
4 years ago
c9be2f02c3
Clean up controllers ( #24340 )
...
* clean up lat controllers
* pass CP once
* sort
4 years ago
f4d1703b42
longActive: consider longitudinal control ( #24295 )
...
* consider longitudinal control
* update refs
4 years ago
fe0bcdaef6
Lateral torque-based control with roll on TSS2 corolla and TSSP rav4 ( #24260 )
...
* Initial commit
* Fix bugs
* Need more torque rate
* Cleanup cray cray control
* Write nicely
* Chiiil
* Not relevant for cray cray control
* Do some logging
* Seems like it has more torque than I thought
* Bit more feedforward
* Tune change
* Retune
* Retune
* Little more chill
* Add coroll
* Add corolla
* Give craycray a good name
* Update to proper logging
* D to the PI
* Should be in radians
* Add d
* Start oscillations
* Add D term
* Only change torque rate limits for new tune
* Add d logging
* Should be enough
* Wrong sign in D
* Downtune a little
* Needed to prevent faults
* Add lqr rav4 to tune
* Try derivative again
* Data based retune
* Data based retune
* add friction compensation
* Doesnt need too much P with friction comp
* remove lqr
* Remove kd
* Fix tests
* fix tests
* Too much error
* Get roll induced error under 1cm/deg
* Too much jitter
* Do roll comp
* Add ki
* Final update
* Update refs
* Cleanup latcontrol_torque a little more
4 years ago
5c48e7bc86
remove comma two support ( #24248 )
...
* remove comma two support
* cleanup release files
* little more
* more libs
* no more gralloc
* add snpe back
4 years ago
067273b8e7
controlsd: check if process should be running ( #24250 )
4 years ago
b9e5ad8a64
fix csid map
4 years ago
49c2164814
add alert for CAN bus timeout ( #24162 )
...
* add alert for CAN bus timeout
* add alert
* set in interface
* cleanup
* cleanup
* add event
* fix mock
* bump
* bump opendbc
* update refs
* return reader
4 years ago
37fc027e98
controlsd: fix soft disable while overriding ( #24178 )
4 years ago
1848050fd9
add cameraFrameRate alert ( #24152 )
...
* add cameraFrameRate alert
* bump cereal
4 years ago
eaa5819211
commIssueAvgFreq: separate alert for avg freq check ( #24150 )
...
* commIssueAvgFreq: separate alert for avg freq check
* bump cereal
* bump cereal
* bump cereal
* freq_ok separate from alive
* bump cereal to master
* update_ref
* fix profiler
4 years ago
7dd71cc63d
body: control with joystick ( #24143 )
...
* control with joystick
* slow it down
* always joystick for not car
* clean ups
* not stateful
* move submaster
* only if we aren't in test mode
* update refs
* double ki speed, update ref
* this ref
Co-authored-by: Comma Device <device@comma.ai>
4 years ago
65fca83abe
Latency logging 2 ( #24058 )
...
* msg_order and gantt
* frameId in long/lat planner
* track frame id
* controls frame id
* graph tracked events
* graph json
* cloudlog timestamp
* c++ cloudlog
* add frame id
* bug fixes
* bug fixes
* frame id visionicp
* bug fixes and debug level
* timestamp log placement
* print timestamps in table
* translate events
* more logging
* bug fixes
* daemon boardd
* print logs with boardd
* more timestamp logs
* cleanup
* remove publish logs
* bug fix
* timestamp received
* timestamp received
* bug fixes
* use json lib
* ignore driver camera
* prep for new timestamp pipeline
* bug fix
* read new pipeline unfinnished
* read new pipeline
* bug fix
* add frame to controlsstate
* remove controlsstate
* print
* cleanup
* more cleanup + bug fix
* clock build issue
* remove unused imports
* format durations
* increase speed
* pr comments fixes
* conflicts
* set MANAGER_DAEMON for boardd
* clean script code
* bug fix + argparse
* remove rcv time
* bug fixes
* print without tabulate
* fix pre-commits
* plot gnatt
* color bug fix
* read without timestampextra
* bump panda
* mono time instead of frame id
* finnish script
* clean unused
* clean unused logging
* monotonic + json fixes
* del test
* remove whilelines
* bump laika
* cleanup
* remove deps
* logs nicer strings
* remove plotting from scirpt
* reset pipfile
* reset pipfile
* nicer strings
* bug fix
* bug fix
* pr comments cleaning
* remove plotting
* bug fix
* new demo route
* bump opendbc and panda
* cereal master
* cereal master
* script less komplex
* assertions
* matplotlib
* readme
* Update README.md
* graph html
* design fixes
* more code design
* Update common/logging_extra.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* whitespace
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update tools/latency_logger/latency_logger.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* pr comments
* bug fix
* readme + env once
* clean swaglog
* bug fix
* Update tools/latencylogger/README.md
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* revert
* revert
* clean swaglog with error
* remove typo file
* revert graph
* cereal
* submodules
* whitespaces
* update refs
Co-authored-by: Bruce Wayne <batman@workstation-openpilot2.internal>
Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
4 years ago
d7a708d6da
tests: add overriding to state machine test ( #24131 )
...
* add overriding to state machine test
* overriding should consider soft disable too
4 years ago
f0ac80806e
controls: add overriding to active states ( #24129 )
4 years ago
f1f40c117a
Add Disengage on Accelerator Toggle ( #23977 )
...
* Squashed commit of the following:
commit 953bcf0ecf8d03f0fec9ce0d5442cc660ae2347d
Merge: b4198608d 333257bad0b9790dd281862fce7d60c44e03⛽ ➡️ 🔋
bump
commit d2b64b89cf8d7265bc90848b4e3a2276c9a4cb78
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Mar 24 16:19:34 2022 -0700
these changes will be in border PR
these changes will be border PR
commit bed31e63de2244c161729773978fef8a9246ddb5
Merge: 491417640 e91613bc6c88ced1f199c02bdd2db7b49c715fe00fb77d7c758d4b🔥
commit 1885c9e2bacd9351c7e421b1436dcbfbde238436
Merge: 1f591736a 9c70e8bca7410160d03e915cf62
4 years ago
00ebd10b87
body: only control while engaged ( #24114 )
...
* body: only control while engaged
* bump panda
* remove that
* bump panda
* update refs
* update refs
4 years ago
2624b4cb27
controlsState: add override state with grey border ( #24030 )
...
* Squashed commit of the following:
commit f0cf822666fb8f78a486d721fe474e8f37da6970
Author: Shane Smiskol <shane@smiskol.com>
Date: Mon Apr 4 17:24:00 2022 -0700
clean up
commit 4364bdb79b1b055daa7542267eb3f37740723fd4
Merge: d448664cf d4f3304470b9790dd2d932cb0678e34ddc70
4 years ago
d4f330447a
controlsd: add state machine tests ( #24107 )
...
* Handle NO_ENTRY in PRE_ENABLED
* add test
* add preEnabled NO_ENTRY test
* stash
* test soft disable
* tuples
* remove overriding until it's merged in
* use Events class
* fix tests and split out
* don't rely on controlsd's counter
4 years ago
49498aa7b5
controlsd: no cruise speed while main off ( #24052 )
...
* controlsd: no cruise speed while main off
* probably more accurate
* update refs
4 years ago
e91613bc62
update unsafeMode to alternativeExperience ( #23995 )
...
* update unsafeMode to alternativeExperience
* fix
* fix
* bump submodules
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
4 years ago
dcece099ff
Add angular rates carcontroller packet ( #23980 )
...
* Controlsd: give carcontroller angular rates
* Update cereal
* Needs to be list
* Update refs
4 years ago
5fe00fb773
Move gas/brake pedal event logic to controlsd ( #23850 )
...
* move some state machine logic to controlsd
move some state machine logic to controlsd
* same order
same order
* move unsafeMode up
* disable at standstill
* save last CS
save last CS
* do we need to copy at all?
* don't copy
* rename
* Update selfdrive/controls/controlsd.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Revert "Update selfdrive/controls/controlsd.py"
This reverts commit 10bb51a0f0ee0d8e2a27c746a0638280a5eaea8a.
* Update refs
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
4 years ago
Shane Smiskol
Robbe Derks
Vivek Aithal
Adeeb Shihadeh
Willem Melching
HaraldSchafer
grekiki
George Hotz
George Hotz
Lukas Petersson