Vivek Aithal
f1fecc3da7
Sensor Invalid Alert ( #25303 )
...
* modify text, add soft disable
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/controls/lib/events.py
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
3 years ago
Vivek Aithal
e77dc1ab44
Lateral Acceleration Error alert (Sensor Invalid) ( #25291 )
...
* sensor flag in paramsd
* increase lateral acc err alert threshold
* add invalid sensor alert from paramsd
* update ref, bool before adding to msg
* account for sign difference in locationd and paramsd
* revert ref
3 years ago
Adeeb Shihadeh
d462a08056
remove CS.steeringRateLimited ( #25251 )
...
* remove CS.steeringRateLimited
* bump cereal
* update refs
3 years ago
Willem Melching
f300a8df2b
use v_cruise_cluster_kph for hudControl.setSpeed ( #25245 )
3 years ago
Willem Melching
c3e95d5e19
prereq for matching speeds shown on cars dash ( #25222 )
...
* prereq for matching speeds shown on cars dash
* also handle fallback in the ui for replay
* update translations
* update ref
3 years ago
Adeeb Shihadeh
278d6893fe
less beeps for steering override faults ( #25196 )
...
* less beeps for steering override faults
* less repeat
3 years ago
Adeeb Shihadeh
505bbce29d
controlsd: handle radar missing + cleanup system error handling ( #25179 )
...
* controlsd: handle radar missing + cleanup system erorr handling
* fix carla
* update refs
3 years ago
Adeeb Shihadeh
2ae52e9b22
process replay: ensure enabled for significant amount of time ( #25121 )
...
* process replay: ensure enabled for significant amount of time
* update refs
* 10s is reasonable
3 years ago
Shane Smiskol
be7f704168
Fix new steer saturated warning with joystick mode ( #25113 )
...
Fix steer sat warning with joystick mode
3 years ago
Shane Smiskol
fd2de54172
Stock longitudinal: spam resume button when lead starts moving ( #24873 )
...
* always log leads, we hide them in ui
* only spam resume when future is > vEgoStarting
* do rest but vw
* vw
* remove comments
* rename to resume
* maintain original button msg rate
* mazda: ensure no resume if cancelling
* same for non-HDA2
* Always run planner if not opLong
* try 0.2
* 0.1 should be pretty safe
* add test for resuming
* fix test
* stricter test, speeds[-1] is 0.14 when starting here
* no walrus
* fixup mazda cc
* remove extra import
3 years ago
Shane Smiskol
ea241bf3dc
FW fingerprinting: log all FW versions ( #25042 )
...
* get_fw_versions returns all fw versions with request's brand
* keep track of everything received
* debug
* need to regen or write a hack in build_fw_dict
* to be safe, still replace old responses within same brands (hyundai responds to two queries, can fix later)
to be safe, still replace old responses within same brands (hyundai responds to two queries, can fix later)
* update test_fw_query_on_routes
* clean up
* better name
* slightly cleaner
* fix test_startup unit test
del
* fix imports
* fix test_fw_fingerprint
fix test_fw_fingerprint
fix
* fingerprint on all FW_VERSIONS, not just brands with requests
* support old routes in test_fw_query_on_routes
* regen and update refs
* similar function style to before
* better comment
* space
switch name
* try to exact match first
* useless else
* fix debug script
* simpler dictionary
* bump cereal to master
3 years ago
Shane Smiskol
f797567ef8
long planner: run when using stock longitudinal ( #25017 )
...
* Squashed commit of the following:
commit e27a5b4e2bfeab4e6a47440b1d4eb180ee4acf49
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Jul 1 14:10:06 2022 -0700
remove this test
remove this test
commit c3c10af82222ea4641d94c53a3a07b486cca8452
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Jul 1 14:08:15 2022 -0700
only planner changes
commit 50e0f1d8704c15acfce8987faf3515c99e8af4f4
Merge: e088fde67 fcc5b3d70
Author: Shane Smiskol <shane@smiskol.com>
Date: Fri Jul 1 14:05:36 2022 -0700
Merge remote-tracking branch 'upstream/master' into enable-planner2
commit e088fde67edcc32ccfeea23b4ae9e44845240429
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Jun 30 13:58:38 2022 -0700
no walrus
commit b7b425e530e949b9cc427833562473cc241d1367
Merge: f8634266b c49f997be
Author: Shane Smiskol <shane@smiskol.com>
Date: Thu Jun 30 13:54:30 2022 -0700
Merge remote-tracking branch 'upstream/master' into enable-planner
commit f8634266b49c3f692b255e6cfac66cccc438ae20
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Jun 29 16:07:35 2022 -0700
stricter test, speeds[-1] is 0.14 when starting here
commit c9e446ad2183feba9d03ee39f9801091ab791c08
Merge: e6c4106ea 879a7c320
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Jun 29 16:01:32 2022 -0700
Merge remote-tracking branch 'upstream/master' into enable-planner
commit e6c4106ea185c68a6c7b3d59d5bde664df8bdc9c
Author: Shane Smiskol <shane@smiskol.com>
Date: Sat Jun 25 03:28:41 2022 -0700
fix test
commit 0520c7f21613b57b804e08a8e8d10950ac059074
Author: Shane Smiskol <shane@smiskol.com>
Date: Sat Jun 25 03:26:16 2022 -0700
add test for resuming
commit 04db5f80bff4a002f5241765a625d7cf57b74364
Merge: e23b37d3f d8bfe2f00
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Jun 22 20:15:50 2022 -0700
Merge remote-tracking branch 'upstream/master' into enable-planner
commit e23b37d3fe8dd3dd07b46a32a4f0564fabade1aa
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Jun 21 12:46:04 2022 -0700
0.1 should be pretty safe
commit e7dc3960da3d713753f28732f50dbd25811fad28
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Jun 21 12:39:30 2022 -0700
try 0.2
commit ff0597ec92a0d2c52915316961ec123b0183c5cf
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Jun 21 11:34:00 2022 -0700
Always run planner if not opLong
commit 13997c55271f79fd3ca62d6db45ec3790b09aa60
Merge: d2f51ee55 95d8517a8
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Jun 21 11:29:22 2022 -0700
Merge remote-tracking branch 'upstream/master' into enable-planner
commit d2f51ee55fd3bde38275371e76714d7741bc6f6b
Author: Shane Smiskol <shane@smiskol.com>
Date: Tue Jun 21 11:27:45 2022 -0700
same for non-HDA2
commit 6a63bd60f09a0abd9185049cd173100d3ef6fefa
Author: Shane Smiskol <shane@smiskol.com>
Date: Mon Jun 20 23:37:07 2022 -0700
mazda: ensure no resume if cancelling
commit 5771cdecab7999765d9f5203c75a67f1555cf975
Author: Shane Smiskol <shane@smiskol.com>
Date: Mon Jun 20 23:27:58 2022 -0700
maintain original button msg rate
commit 6c1fe0606fd0a0819ffeaac92526e43b3110f2f4
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Jun 15 23:45:26 2022 -0700
rename to resume
commit 00b1df652f1679137c769f9db61eed7dd14e1542
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Jun 15 21:57:54 2022 -0700
remove comments
commit 325ea9bbd5e0dd946961ede0cdcc446ad5e5bbdb
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Jun 15 21:56:20 2022 -0700
vw
commit 2c9061042b36fe1d6b029a4216655be69a980849
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Jun 15 21:54:37 2022 -0700
do rest but vw
commit 3dc51f663dfdd4ea1fd72d239bcd5db8c7da4b47
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Jun 15 16:34:48 2022 -0700
only spam resume when future is > vEgoStarting
commit 5f32cd1fcb402bee425d866a9dc76b6feea3d241
Author: Shane Smiskol <shane@smiskol.com>
Date: Wed Jun 15 16:09:43 2022 -0700
always log leads, we hide them in ui
* reset when not CS.enabled
remove comment
* update refs
3 years ago
Willem Melching
d4cc13c88a
controlsd: avoid lag on first iteration due to get_short_branch ( #25031 )
...
* controlsd: avoid lag on first iteration due to get_short_branch
* always cache
3 years ago
HaraldSchafer
0c95493dc0
Torque control: max torque warning ( #25018 )
...
* New steer torque warning
* typo
3 years ago
Willem Melching
cdc7a6dbea
enable laikad ( #25013 )
...
* enable laikad
* increase logprint for onroad test
3 years ago
HaraldSchafer
b3226d505b
Torque control: higher low speed gains and better steering angle deadzone logic ( #24980 )
...
* Try no friction and no deadzone
* Learn fromd ata
* update refs
3 years ago
Adeeb Shihadeh
062a8bcdbd
cleanup torque tuning config ( #24951 )
3 years ago
Willem Melching
88f246b909
ui: change alerts to Inter ( #24937 )
...
* ui: change alerts to Inter
* fix up test
3 years ago
HaraldSchafer
2c877ce490
Long e2e planner: better xva weights ( #24893 )
...
better long xva weights
3 years ago
Adeeb Shihadeh
7c826b4fa1
add param to override carParams.dashcamOnly ( #24857 )
...
* add param to override carParams.dashcamOnly
* little cleaner
3 years ago
grekiki
b941b39c56
More accurate jerk limits ( #24755 )
...
* More accurate jerk limits
* Min is not - max
For example max_curvature_rate can be negative.
* reduce diff
3 years ago
HaraldSchafer
9283040d84
Rocket league model ( #24869 )
...
* dd9a502d-c8e2-4831-b365-804b0ae0739d/600 80041070-d276-4fed-bdb9-0075e5442908/420
* no elementwise op
* 9dabf0fe-2e60-44bf-8d3a-d20a74aca072/600 ae746590-0bb5-4a16-80db-15f02d314f03/300 c4663a12-b499-4c9b-90dd-b169e3948cb1/60
* explicit slice
* some copies are useful
* 1456d261-d232-4654-8885-4d9fde883894/440 c06eba55-1931-4e00-9d63-acad00161be0/700 af2eb6ba-1935-4318-aaf8-868db81a4932/425
* 154f663e-d3e9-4020-ad49-0e640588ebbe/399 badb5e69-504f-4544-a99e-ba75ed204b74/800 08330327-7663-4874-af7a-dcbd2c994ba7/800
* set steer rate cost to 1.0
* smaller temporal size
* Update model reg
* update model ref again
* This did upload somehow
* Update steer rate cost
Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
3 years ago
HaraldSchafer
a6652a539d
Torque control: low speed boost ( #24859 )
...
* Make very low speed more aggressive
* Less extreme low speed boost
* Update ref
3 years ago
Adeeb Shihadeh
0fce5d9045
Move a bunch of stuff to system/ part 3 ( #24829 )
...
* move swaglog.py
* timezoned
* logmessaged
* version.py
* fix linter
3 years ago
Adeeb Shihadeh
1139fe507b
Move selfdrive/hardware/ to system/ ( #24725 )
...
* move hardware to system/
* fix mypy
3 years ago
HaraldSchafer
843e59f6f0
Misc torque control fixes ( #24801 )
...
* Fiction compensation should be based on error
* Update refs
* Add deadzone
* update ref
3 years ago
ClockeNessMnstr
b215d611b1
update DH names + notes for MPC output curvatures ( #24701 )
...
* update names + notes for MPC outputs
"current_curvature" is not the correct description of what the MPC is outputting in it's curvature_ego state.
The MPC is integrating it's free variable, curvature_rate, such that curvature[0] is actually the desired_curvature before any delay.
inversely: the curvature_rate_desired is the desired rate of change to the setpoint and not the actual curvature rate.
If we were to set the initial curvature = measured curvature in the MPC initiation these names would be correct.
This was possibly how it was initially set up but the nomenclature here is now confusing.
* more notes
* match
* Clarify #1
3 years ago
Shane Smiskol
c6bc03311c
Car documentation: set steering torque star using car interface ( #24709 )
...
* Set good torque using torque controller tuning
* should be equal to
* save lateral accel to car params
* use maxLateralAccel
* always
* same convention
* nan will always evaluate to false
* The great good torque purge
* adjust default friction
* Add data for more cars
* adjust name
* Welcome back, guys. Only adjust good torque if maxLatAccel is set
* Update refs (1.7 is 1.7000001...)
3 years ago
HaraldSchafer
7f16e19f79
Remove laneless toggle ( #24738 )
...
* Remove laneless toggle
* Update refs
3 years ago
Willem Melching
f49a9c9fd2
less TICI when not needed ( #24698 )
...
* less TICI when not needed
* fix process replay
* move reading voltages into hw abstraction layer
* Update selfdrive/hardware/tici/hardware.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/hardware/hw.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Update selfdrive/hardware/base.h
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* rename init function
* Update selfdrive/athena/athenad.py
Co-authored-by: Robbe Derks <robbe.derks@gmail.com>
* Update selfdrive/boardd/boardd.cc
* Apply suggestions from code review
* Update selfdrive/thermald/thermald.py
* update ref
* fix alert width if all cameras are bad
* add ecam to test_loggerd
* bump cereal
* bump cereal
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Robbe Derks <robbe.derks@gmail.com>
3 years ago
Gijs Koning
b5aed2bf67
Simulator: Speed up process by removing second camera ( #24679 )
...
* simulator: support running wide camera only
* proper frame id
* use param name that makes more sense
* do some cleanup
* Update tools/sim/bridge.py
Co-authored-by: Willem Melching <willem.melching@gmail.com>
3 years ago
HaraldSchafer
d708a134bd
Tssp prius torque control ( #24669 )
...
* use llk
* use steering sensor at low speed stil
* Try more simple
* rm prius tune
* updated ref
3 years ago
HaraldSchafer
d928972150
Rerevert torque control ( #24649 )
...
* Revert "Revert torque control (#24565 )"
This reverts commit 9f8b03753d
.
* Move tune out of car specific stuff
* Update ref commit
3 years ago
HaraldSchafer
7da48ebdba
New model: better laneless ( #24605 )
...
* Fix ping pong
* Fix hugging: e6fd3a62-aa86-46d1-a414-19137ed1babc/800
* Remove lateral toggle
* a6da6265-1952-48dd-986b-2b5996dd2642/950
* Model replay commit
* Revert "Remove lateral toggle"
This reverts commit 69e57eb7e1a72e4bad5e12bcfded6ff431a21a0e.
3 years ago
Adeeb Shihadeh
71901c94db
controlsd: ensure all system malfunction events have the right types ( #24635 )
3 years ago
HaraldSchafer
2181bbca71
Latcontrol torque: integrator need not be reset ( #24606 )
...
slow integrators need not be reset
3 years ago
Shane Smiskol
d3d210c183
controls: pressing set while gas pressed resets to vEgo ( #24100 )
...
* set while gas pressed to resume
* better order
* what was I thinking?
* Update selfdrive/controls/lib/drive_helpers.py
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
* Update selfdrive/controls/lib/drive_helpers.py
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
* only if under set speed
* some clean up and ciel the v_cruise_kph
* clean up
* actually floor
* Should be cruise min
* On phone, will clean up
* Think no floor is fine
* clean up and catch setCruise
* update comment and just always do rounding and clipping
update comment
* flip order
Co-authored-by: Gijs Koning <gijs-koning@live.nl>
3 years ago
HaraldSchafer
9f8b03753d
Revert torque control ( #24565 )
...
* torque reversal start
* Fix carmodel tests
* Update ref
* update ref
* Elif is better than if
3 years ago
Adeeb Shihadeh
0b1f6e3620
show which cameras are malfunctioning ( #24558 )
3 years ago
Adeeb Shihadeh
b1858df00e
improved alert verbosity ( #24434 )
...
* improved alert verbosity
* better testing script
* better description
* speed diff
* touch ups
* fix that
3 years ago
Shane Smiskol
961a121fde
Round system overheated temperature ( #24544 )
...
* Update events.py
* Apply suggestions from code review
Co-authored-by: Willem Melching <willem.melching@gmail.com>
3 years ago
ntegan1
076f0acd5f
Round model lagging frame drop percentage ( #24549 )
...
alerts: round model frame drop percentage
3 years ago
Willem Melching
31af13101b
Add unittest for alert callbacks ( #24551 )
...
add alert callback test
3 years ago
ClockeNessMnstr
a693b3a26b
LatControlTorque: clean up class variable ( #24526 )
...
* move to super
* no class variable
* there's CP
* whitespace
* drop CI from latcontrol super
* Revert "drop CI from latcontrol super"
This reverts commit 9218273060ade6431c4fc4c310b27e7e210158b9.
Co-authored-by: Shane Smiskol <shane@smiskol.com>
3 years ago
Shane Smiskol
6518ecca8f
Add desired curvature to controlsState ( #24510 )
...
* Add desired_curvature to controlsState
* clean up
* bump
* bump
* update refs from GitHub!
Co-authored-by: Jason Shuler <jshuler@gmail.com>
3 years ago
Dylan Herman
d2eef1955c
add mypy check for return-any ( #24379 )
...
* add mypy check for return-any
* remove unused import
* typing
* remove unnecessary variable typing
* cleanup
* cleanup
* bump submodules
* small fixes
* only a problem on mac
Co-authored-by: Willem Melching <willem.melching@gmail.com>
3 years ago
grekiki
17e33978cd
Mypy fixes for --check-untyped-defs ( #24372 )
...
more type fixes
3 years ago
HaraldSchafer
29afd53d88
Latcontrol torque: fix integrator induced ping pong ( #24458 )
...
* Latcontrol torque: fix integrator induced ping pong
* Reset on disengage since unwind resets anywayh
* Might be overkill
* rm whitespace
* update ref
3 years ago
Adeeb Shihadeh
1bc6f2fa7d
increase cruiseMismatch threshold ( #24428 )
3 years ago
ntegan1
9a44d4c4e0
LatControlTorque: log desired/actual lateral accel ( #24406 )
...
* log torque lateral accel
* bump cereal
* update refs
Co-authored-by: Shane Smiskol <shane@smiskol.com>
3 years ago