* ban cereal and msgq
* common too
* do toyota/values.py
* do all fingerprints
* example without builder
* this still works, but no type checking anymore
* stash
* wtf, how does this work
* okay actually not bad
* safe
* epic!
* stash data_structures.py
* some clean up
* hell yeah
* clean up old file
* add to delete
* delete
This reverts commit 90239b7797ace31ee647a2fdbd67e0c3faa98dcf.
* switch more CarParams stuff over
remove unused
* fix car tests by removing cereal! mypy forgets about dataclass if we wrap it :(
* fix this too
* fix this too
* remove more cereal and add some good hyundai tests
* bunch more typing
* override default with 20hz radar
* temp capnp converter helper
* more lateralTuning
* small union replicator is better than what i was trying, and fixes mypy dynamic typing issues
* can keep all this the same now!
* type ret: CarParams, add more missing structs, revert lateralTuning changes (smaller diff!)
* revert more
* get first enum automatically, but ofc mypy doesn't pick up the new metaclass so can't use :(
would have been `CarParams.NetworkLocation()`
* Revert "get first enum automatically, but ofc mypy doesn't pick up the new metaclass so can't use :("
This reverts commit bb28b228becba932052d2fc5a4389784027435b1.
* remove cereal from car_helpers (TODO: caching)
* remove a bunch of temp lines
* use dataclass_transform!
* remove some car.CarParams from the interfaces
* remove rest of car.CarParams from the interfaces
* same which() API
* sort
* from cereal/cache from fingerprinting!
* more typing
* dataclass to capnp helper for CarParams, cached it since it's kinda slow
* (partial) fix process replay fingerprintig for new API
* latcontrollers take capnp
* forgot this
* fix test_models
* fix unit tests
* not here
* VehicleModel and controller still takes capnp CP since they get it from Params()
* fix modeld test
* more fix
* need to namespace to structs, since CarState is both class and struct
* this was never in the base class?!
* clean that up again
* fix import error
fix import error
* cmts and more structs
* remove some more cereal from toyota + convert CarState to capnp
* bruh this was wrong
* replace more cereal
* EventName is one of the last things...
* replace a bunch more cereal.car
* missing imports
* more
* can fix this typing now
* proper toyota+others CS typing!
* mypy can detect return type of CS.update() now
* fix redeclaration of cruise_buttons type
* mypy is only complaining about events now
* temp fix
* add carControl struct
* replace CarControl
i hope there's no circular imports in hyundai's CC
* fine now
* lol this was wrong too
* fix crash
* include my failed attempts at recursively converting to dataclass (doesn't implicitly convert types/recursively :( )
but attrs does, maybe will switch in the future
* clean up
* try out attr.s for its converter (doesn't work recursively yet, but interesting!)
* Revert "try out attr.s for its converter (doesn't work recursively yet, but interesting!)"
This reverts commit ff2434f7bbd45a4d4bfb21f7d6712d1f1c3bcde9.
* test processes doesn't fail anymore (on toyota)!
* fix honda crash
* stash
* Revert "stash"
This reverts commit c1762af4e776790e4ad1322ad4ce0610157346e0.
* remove a bunch more cereal!
* LET'S GOOO
* fix these tests
* and these
* and that
* stash, something is wrong with hyundai enable
* Revert "stash, something is wrong with hyundai enable"
This reverts commit 39cf327def258e2959fe23cd7a550a858f6d8f03.
* forgot these
* remove cereal from fw_versions
* Revert "remove cereal from fw_versions"
This reverts commit 232b37cd409b55d04b1afc90d4a80c49e710eb56.
* remove rest of the cereal exceptions!
* fix that
* add typing to radard since I didn't realize RI.update() switched from cereal to structs
* and here too!
* add TODO for slots
* needed CS to be capnp, fix comparisons, and type hint car_specific so it's easier to catch type issues (capnp isn't detected by mypy :( )
* remove the struct converter
* save ~4-5% CPU at 100hz, we don't modify after so no need to deepcopy
btw pickle.loads(pickle.dumps()) is faster by ~1% CPU
* deepcopy -> copy: we can technically make a reference, but copy is almost free and less error-prone
saves ~1% CPU
* add non-copying asdict function
* should save ~3% CPU (still 4% above baseline)
* fix that, no dict support
* ~27% decrease in time for 20k iterations on 3X (3.37857 -> 2.4821s)
* give a better name
* fix
* dont support none, capitalize
* sheesh, this called type() on every field
* remove CS.events, clean up
* bump card %
* this was a bug on master!
* add a which enum
* default to pid
* revert
* update refs
* not needed, but consistent
* just Ecu
* don't need to do this in this pr
* clean up
* no cast
* consistent typing
* rm
* fix
* can do this if we're desperate for the last few %
* Revert "can do this if we're desperate for the last few %"
This reverts commit 18e11ac7883a0a56583750b1cc5a2b13011e7299.
* type this
* don't need to convert carControl
* i guess don't support set either
* fix CP type hint
* simplify that
* with brand name
* migrate
* Fix
* fixes
* more
* passes
* fix
* fix the doc
* collects
* these too
* more stuff
* body exception :/
* more
* hardcode i guess
* update ref
* toyota
* more toyota
* and here
* final!
* fix notebooks and ccs
* move this here
* get platform_str from the enum name
* fix tests
* add migration table
* remove impossible todo
* Add link to PR in MIGRATION table
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Remove useless brand name comments and rename RAM_1500 to RAM_1500_5TH_GEN
* rename RAM_HD to RAM_HD_5TH_GEN
* rename references to RAM_HD and RAM_1500
* change "mock" to "MOCK" and rename torque data of Nissan Leaf 2018 IC
* remove MOCK from fingerprints.py
* change hard-coded car model in test_can_fingerprint.py/test_timing
* migration
* update ref
* space
* prius
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: justin newberry <justin@comma.ai>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
* flags
* update ref
* use the flags directly
* use post_init (don't freeze)
* we can maintain frozen with custom class
* not preglobal
* move to common
* cleanup
* bump
* from https://github.com/commaai/openpilot/pull/27929
* get VIN on bolt!
* might as well try on other gms
* remove vin
* ugh gm is going to be slow
* fix
* should really fix this
* revert
* happy?1
* fix unit test
* bump
* functional addressing must be an OBD gateway feature, this does nothing
* fix vin response
* fix addr!
* finally fix fw_versions bugs since boardd IsOnroad refactor
* for
* only bus 0
* clean up
* Update selfdrive/car/gm/values.py
* ChatGPT re-write
* filter out did
* todo
* oof
* preview: what multiple DIDs per ECU would look like in the future
* Revert "preview: what multiple DIDs per ECU would look like in the future"
This reverts commit 88f0d8611e638de644adc5feabade848c03d59e4.
* function to get all ecus
* we can remove this!
* can also do this!
* and this one too :o
* consistency
* yay
* clean up
* add CADILLAC ESCALADE ESV PLATINUM 2019
* add test route
* Update selfdrive/car/gm/interface.py
* combine params
* that's just a trim
* wow, there's a huge torque offset (left is 1.2 m/s^2, right is 1.9 m/s^2 max lat accel)
* don't hard code
* Update selfdrive/car/torque_data/override.yaml
* consistent formatting
* add to releases
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* timing test
* test
* fix
* print
* loop
* clean up
* wider range
* Update selfdrive/car/tests/test_models.py
* Apply suggestions from code review
* run many times
* Update selfdrive/car/tests/test_models.py
* run for many its
* run with unittest and print as list
* Update .github/workflows/selfdrive_tests.yaml
* Update .github/workflows/selfdrive_tests.yaml
* total time is super inconsistent (body)
* Update selfdrive/car/tests/test_models.py
* clean up
* clean up
* clean up
* this works!
* draft
* test suite not as modular
* try something like this
* can do kb, but not too representative
* clean up
* remove kb? it depends on signals
* clean up
* more clean up
* rename
* just measure all CANParsers
* can do all this manually
* but this is way simpler
* comment
* stash
* draft
* draft
* remove old script
* clean up
* revert
* use it
* remove test
* opt
* no partial
* remove
* revert test_models
* test can fingerprinting
* so much simpler!
* fix dict resizing
* simplify
* need to do this
* fix
* move to new file
* rename
* comment
* ignore function-uses-loop-variable
* add missing addresses FP for silverado
* add for all camera acc gm
* add test
* check both rx and tx
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* more stuff
* even more
* all parts func
* start to use it
* include self in parts
* use car_parts_new
* not used
* more usages
* remove get_parts
* remove more commented stuff
* remove iter
* clean up some more stuff
* more
more
* ford
* optional
optional
* nissan
* use new classes
* fix tests
* fix
* order
* no more required
* connector
* CARS.md
---------
Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
* generic car parts
* better carparts
* add part type
* more tests
* multiple enums
* unit tests
* just check isinstance
* better name
* remove _connector suffix
* remove those hyundai lines
* remove default arg
* Revert "remove default arg"
This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.
* cleaner code structure
* use fingerprint
* review
* abstrac data class + common
* no more dataclass
* conflict
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* add harness kit content to the doc
* parts as enum
* nissan
* merge column
* rename column
* scaling
* scaling again
* 500px
* align text
* more px
* add style
* more width
* more
* more
* smaller text
* make all text smaller
* prev width
* default list
* remove hidden a ref
* try to remove again
* revert
* replace harness with harness_kit
* try fix
* cleaner
* center everything
* make pylint happy
* allow more than 1 of each parts
* use copy module
* review
* testing spacing
* revert
* bigger text
* formating
* split harness col lines
* remove print
* resolve
* rename to view
* keep formating in template
* simplify
* add unit test
* more generic way
* better
* harness connector only
* comment
* review
* put back harness parts
* missing dash
* too much space
* don't reload when clicking
* shorter comment
* only last line
* generate
---------
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Add trailblazer support
* Update routes.py
* Update routes.py
* Update CARS.md
* Fix incorrect torque name
* Update values.py and CARS.md
* Change to update another route
* update docs
* only 2021 https://en.wikipedia.org/wiki/Chevrolet_Trailblazer_(crossover)
only 2021
* new FP with missing addrs
* Update selfdrive/car/gm/interface.py
* tune the torque params
* update docs
* remove as a new platform
* Revert "remove as a new platform"
This reverts commit c9c65f29dbb1e1a5926540bb75433928325d6c0e.
* add comment and comment out FP
* need it to be in all_known_cars to test_model
* add to releases
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* add erf based ff
* silly bug; diff of nonlinear != nonlinear of diff
* add sigmoid based ff, ensure slope at 0 > 1
* reduce steer down limit and increase driver allowance
* rebase panda
* atry without friction, and with tanh nonlinear
* finalize the nonlinear function
* do not disable friction compensation in the ff
* bump panda
* bump panda
* update refs
* update refs
* resolve comments
* Add type hints
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Add flashed Volt fingerprint
* Add another fingerprint
* Detect radar header message
* dashcamOnly if ASCM vehicle with radar unavailable
May be able to change this in the future to OP long off with experimental long available
* no submodule update
* Revert minEnableSpeed
* combine into one fingerprint
* Don't use GM radar DBC
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* unused
* add new FP
* update docs
* use_off_car_defaults
use_off_car_defaults
* update docs
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* stash
* more test
* less test
* clean test
* no angle
* add tolerance
* fix gm
fix gm
* test both
* lower some rates on hkg
* stash
* simpler
* bump panda
* Revert "bump panda"
This reverts commit f2137c221145cca723fe6ee3378ba947b7061965.
* only torque
* make kona pass
* duplicate __init__
* move
* half clean up
* half clean up
* more clean up
* more clean up
* fix static analysis
* calculate over 0.5 seconds
* limit to max steer
* type annotation
* calc once
* add a hook function for makes to implement custom docs logic
* don't need this
* use the pre-defined list for honda's harnesses
* one line 😎
* Update selfdrive/car/docs_definitions.py
* i didn't know you didn't need a pass!
* don't change docs order
* put gm camera voacc behind disable radar toggle
* bump panda
* bump panda
* bump panda
* experimental long
* fixes
* car control notes and fixes for Bolt EUV
* might enable stop and go
* consistent name
* min enable speed seems to be around 5 kph
* camera acc can engage under 5 kph if stopped
* comment
* comment
* remove this for now
* only real brake
* comments
* update max brake
* bump
* clean up/fix
* same if
* simplify
* fix
* old comment
* no brake_pressed
* temporary fault fix
* tune longitudinal
* update docs
* bump panda
* GM camera ACC cars have no regen in ACC
* cleaner
* cleaner
* fix
* set max gas
* fixes
* fix LKAS unavailable warning from camera
* only camera
* bump panda
* bump panda
* bump panda
* bump panda
* clean up gmcan
* clean up CC
* flip
* rm
* rm comment
* clean up
* custom starting/stopping probably not needed
* Update selfdrive/car/gm/carcontroller.py
* fix crash
* long tuning
* we need long control state to resume
* CAMERA_ACC_CAR not needed
* no interp on accel
* tuning
* formatting
* formatting
* formatting
* formatting
* formatting
* no need to init ccp
* makes more sense now
* send at 10hz when inactive
* try to make it fine to switch rates
* fix rate
* todododo
* fine if we skip, we usually send too early
* clean up
* this may be required, 50Hz is not really needed to sync/initialize
* preserves previous behavior (not sure if this makes sense)
* Revert "preserves previous behavior (not sure if this makes sense)"
This reverts commit 3b297bca72307b5cba09bec4e2cd8e0f2761af42.
* Revert "this may be required, 50Hz is not really needed to sync/initialize"
This reverts commit a6b4693814214d3f508db922f3b371c402a13995.
* rm com
* Update ref_commit
* gate behind GM Cam
* common logic
* bet
* update refs
* -4 didn't make any sense?
* comments
* comments
* update to 400
* bump panda
* remove unused iso limit vars
* update comments
* bump panda
* Update selfdrive/car/gm/values.py
* Update ref_commit
* Chevy Bolt EV w ACC Port
* dashcam
* The website allows you to select the package without ACC
* fix Bolt E(U)V centerToFront
* Update selfdrive/car/gm/values.py
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Shane Smiskol
Eric Brown
Justin Newberry
thenhnn
Cameron Clough
Adeeb Shihadeh
Tim Wilson
morrislee
Maxime Desroches
Yong-seok, Jang
Vivek Aithal
koch-cf
Ricky Gilleland
Jason Shuler