#!/usr/bin/env python3
from collections import defaultdict
from typing import Any , DefaultDict , Dict , List , Optional , Set
from tqdm import tqdm
import capnp
import panda . python . uds as uds
from cereal import car
from common . params import Params
from selfdrive . car . ecu_addrs import get_ecu_addrs
from selfdrive . car . fw_query_definitions import AddrType , EcuAddrBusType
from selfdrive . car . interfaces import get_interface_attr
from selfdrive . car . fingerprints import FW_VERSIONS
from selfdrive . car . isotp_parallel_query import IsoTpParallelQuery
from system . swaglog import cloudlog
Ecu = car . CarParams . Ecu
ESSENTIAL_ECUS = [ Ecu . engine , Ecu . eps , Ecu . abs , Ecu . fwdRadar , Ecu . fwdCamera , Ecu . vsa ]
FUZZY_EXCLUDE_ECUS = [ Ecu . fwdCamera , Ecu . fwdRadar , Ecu . eps , Ecu . debug ]
FW_QUERY_CONFIGS = get_interface_attr ( ' FW_QUERY_CONFIG ' , ignore_none = True )
VERSIONS = get_interface_attr ( ' FW_VERSIONS ' , ignore_none = True )
MODEL_TO_BRAND = { c : b for b , e in VERSIONS . items ( ) for c in e }
REQUESTS = [ ( brand , config , r ) for brand , config in FW_QUERY_CONFIGS . items ( ) for r in config . requests ]
def chunks ( l , n = 128 ) :
for i in range ( 0 , len ( l ) , n ) :
yield l [ i : i + n ]
def is_brand ( brand : str , filter_brand : Optional [ str ] ) - > bool :
""" Returns if brand matches filter_brand or no brand filter is specified """
return filter_brand is None or brand == filter_brand
def build_fw_dict ( fw_versions : List [ capnp . lib . capnp . _DynamicStructBuilder ] ,
filter_brand : Optional [ str ] = None ) - > Dict [ AddrType , Set [ bytes ] ] :
fw_versions_dict : DefaultDict [ AddrType , Set [ bytes ] ] = defaultdict ( set )
for fw in fw_versions :
if is_brand ( fw . brand , filter_brand ) and not fw . logging :
sub_addr = fw . subAddress if fw . subAddress != 0 else None
fw_versions_dict [ ( fw . address , sub_addr ) ] . add ( fw . fwVersion )
return dict ( fw_versions_dict )
def get_brand_addrs ( ) - > Dict [ str , Set [ AddrType ] ] :
brand_addrs : DefaultDict [ str , Set [ AddrType ] ] = defaultdict ( set )
for brand , cars in VERSIONS . items ( ) :
# Add ecus in database + extra ecus to match against
brand_addrs [ brand ] | = { ( addr , sub_addr ) for _ , addr , sub_addr in FW_QUERY_CONFIGS [ brand ] . extra_ecus }
for fw in cars . values ( ) :
brand_addrs [ brand ] | = { ( addr , sub_addr ) for _ , addr , sub_addr in fw . keys ( ) }
return dict ( brand_addrs )
def match_fw_to_car_fuzzy ( live_fw_versions , match_brand = None , log = True , exclude = None ) :
""" Do a fuzzy FW match. This function will return a match, and the number of firmware version
that were matched uniquely to that specific car . If multiple ECUs uniquely match to different cars
the match is rejected . """
# Build lookup table from (addr, sub_addr, fw) to list of candidate cars
all_fw_versions = defaultdict ( list )
for candidate , fw_by_addr in FW_VERSIONS . items ( ) :
if not is_brand ( MODEL_TO_BRAND [ candidate ] , match_brand ) :
continue
if candidate == exclude :
continue
for addr , fws in fw_by_addr . items ( ) :
# These ECUs are known to be shared between models (EPS only between hybrid/ICE version)
# Getting this exactly right isn't crucial, but excluding camera and radar makes it almost
# impossible to get 3 matching versions, even if two models with shared parts are released at the same
# time and only one is in our database.
if addr [ 0 ] in FUZZY_EXCLUDE_ECUS :
continue
for f in fws :
all_fw_versions [ ( addr [ 1 ] , addr [ 2 ] , f ) ] . append ( candidate )
matched_ecus = set ( )
candidate = None
for addr , versions in live_fw_versions . items ( ) :
ecu_key = ( addr [ 0 ] , addr [ 1 ] )
for version in versions :
# All cars that have this FW response on the specified address
candidates = all_fw_versions [ ( * ecu_key , version ) ]
if len ( candidates ) == 1 :
matched_ecus . add ( ecu_key )
if candidate is None :
candidate = candidates [ 0 ]
# We uniquely matched two different cars. No fuzzy match possible
elif candidate != candidates [ 0 ] :
return set ( )
# Note that it is possible to match to a candidate without all its ECUs being present
# if there are enough matches. FIXME: parameterize this or require all ECUs to exist like exact matching
if len ( matched_ecus ) > = 2 :
if log :
cloudlog . error ( f " Fingerprinted { candidate } using fuzzy match. { len ( matched_ecus ) } matching ECUs " )
return { candidate }
else :
return set ( )
def match_fw_to_car_exact ( live_fw_versions , match_brand = None , log = True ) - > Set [ str ] :
""" Do an exact FW match. Returns all cars that match the given
FW versions for a list of " essential " ECUs . If an ECU is not considered
essential the FW version can be missing to get a fingerprint , but if it ' s present it
needs to match the database . """
invalid = set ( )
candidates = { c : f for c , f in FW_VERSIONS . items ( ) if
is_brand ( MODEL_TO_BRAND [ c ] , match_brand ) }
for candidate , fws in candidates . items ( ) :
config = FW_QUERY_CONFIGS [ MODEL_TO_BRAND [ candidate ] ]
for ecu , expected_versions in fws . items ( ) :
ecu_type = ecu [ 0 ]
addr = ecu [ 1 : ]
found_versions = live_fw_versions . get ( addr , set ( ) )
if not len ( found_versions ) :
# Some models can sometimes miss an ecu, or show on two different addresses
if candidate in config . non_essential_ecus . get ( ecu_type , [ ] ) :
continue
# Ignore non essential ecus
if ecu_type not in ESSENTIAL_ECUS :
continue
# Virtual debug ecu doesn't need to match the database
if ecu_type == Ecu . debug :
continue
if not any ( found_version in expected_versions for found_version in found_versions ) :
invalid . add ( candidate )
break
return set ( candidates . keys ( ) ) - invalid
def match_fw_to_car ( fw_versions , allow_exact = True , allow_fuzzy = True , log = True ) :
# Try exact matching first
exact_matches = [ ]
if allow_exact :
exact_matches = [ ( True , match_fw_to_car_exact ) ]
if allow_fuzzy :
exact_matches . append ( ( False , match_fw_to_car_fuzzy ) )
for exact_match , match_func in exact_matches :
# For each brand, attempt to fingerprint using all FW returned from its queries
matches = set ( )
for brand in VERSIONS . keys ( ) :
fw_versions_dict = build_fw_dict ( fw_versions , filter_brand = brand )
matches | = match_func ( fw_versions_dict , match_brand = brand , log = log )
HKG: use platform codes to fuzzy fingerprint (#28531)
* get gas/ev/hev from FW (not all correct, poc)
* add test for essential ecus for fuzzy fingerprinting
* kinda works
* stash
* clean up
* add code
* simpler
* use the function
* test it with our cars
* no re
no re
no re
* debugging
* handle empty dict
* simpl
* this is promising
start on making existing fingerprinting functions use the config, instead of entirely replacing them
* needs to allow 1 match
* lay out how this should look
* changes
* executable
* some work
* use config
* fuzzy ecus
* config test
* comment and some clean up
* test platform codes
* use regex, simpler and fixes bug
* in func
* rm bad func
* typing for new func and remove old from dc
* todo done
* tested!
* remove fake platform codes
* thought we needed this, but actually...
* not needed
* not applicable any more
* use config for essential ecus
* first draft of test to make adding/removing fuzzy FP platform intentional
* compile
* clean up test
* even cleaner
* fix default ecus type
* temp fix
* this is mostly in tests now
* test every fuzzy ecu fw returns one platform code
* experiment with dates
* Revert "experiment with dates"
This reverts commit 3251b9cc5c3ca41ca92c8b75ad9b2234b720aa0b.
* clean that up
* comment
* test
* work on all cars
* fix fuzz_fw_fingerprint
* comment
* get first by search
* bit more clean up
* and more
* use compiled pattern for nicer syntax
* default
* flip dat around, much cleaner
* clean up hyundai test a bit
* flip order
same here
* rename test and flip subTest
* fix pylint
* revert fw changes
revert fw changes
* line
* add original functions to test
* needs to be a list
* cmt
* draft (need to count one ecu as a match)
* tiny clean up
* todo: date range
* only in notebook
* remove comment (still can be either list or set)
* same, only notebook
* more consistent signature
* copilot inspired
* copilot no good
* test for date parsing
* better name
* good, now we don't have to worry about the dates mismatching in another test/logic
* comment up+
* some stuff
* clean up
fix test
fix test
* test
* comment
* use utils
* clean up (utils are cleaner and less buggy)
* clean up (utils are cleaner and less buggy)
* fixup test
* use a dash (prettier) and remove some platforms that can fingerprint now!
* compile global pattern
* same as what we do in values
* remove comments
* fuzzy_get_platform_codes is one or none here
* more clean up
* sort imports
* woah woah woah
* add comment
* fix reassigning different types
* add types
* adapt fuzzy test recently added (nice it caught this!)
* update lock
* options
comments
* stash
* comments and fixes
* better comments
* better
* test: run on exact fuzzy matching logic, same results!
* use match_fw_to_car
* test all fw
* ex
* unused random
* this is a possibility
* this is more clear
* fix
* revert
* revert to needing both ECUs to match to reduce false positives, test
* fix excluded platform test :( but it's ok
* add comment
* we actually want to only test fuzzy ecus to make it explicit
* fix mypy
* comment for tomorrow
* just add matches with fuzzy FP
* add comment
* this was the cleanest I could think of, but still working on it. not very easy to understand
* think this is better, but also worse...
* comment: reframing how this works
* revert back to what we did before
* was swapped
* else set
* remove old comment
* fixes from merge
* remove fuzzy_min_match_count from this pr
* fix static analysis
* also unused
* different method first draft
* copy existing fuzzy func
* check all possible ecus exist, only platform codes, slightly refactor main loop
* fix
* Revert recent
Revert "fix"
This reverts commit 5cdb7bda835f1e48e750ab4195e891afe08e11ea.
Revert "check all possible ecus exist, only platform codes, slightly refactor main loop"
This reverts commit d3e918fa20fa4ce881445850f5f7428a3c11adf8.
Revert "copy existing fuzzy func"
This reverts commit 34c8c0545097c84f55f4b4f61907606c93760ddd.
Revert "different method first draft"
This reverts commit b91139055d7d1802c1eb726504798c156a183c9c.
* new func
* fixup test
* remove changes from v1 from fw_versions.py
* clean up a bit
* return part as part of code
* fix test
* add original fuzzy function
* add an ecu match if the date is within range (or date doesn't exist)
* add format for what we're going to do
* not working stash
* the exact matching function does more of what we want with less code and less custom logic
* we don't care about found versions, only codes and dates
* actually we do have an exception
* this works pretty nicely now
* up here
* this is better
* some minor clean up
* old function=now junk
* fix platform code test
* remove old platform code function
* now rename _new to
* use FW_QUERY_CONFIG
* clean up imports
* rename that too
* one line
* correct typing
correct typing
* draft tests
* so that works
* fixup excluded platform test now too
* this is tested by excluded platform test
* test parts and dates
* remove old comment
* old import
* take platform code stuff out of FwQueryConfig
* fix test
* revert debug script
* flip order
* make this a set by default
* revert this part
* correct typing
* clean up comments
* clean that test up too/pylint
* combine these three tests ina clean way
* not right
* more general
* be consistent with quotes
* comment
* comment
* comment in fw_versions
* flip order
* this is more readable
* could test all this, but it's tested in test_hyundai and doesn't do a lot here
* only assert brands which use this
* invalidate all CAN FD ICE and hybrid
* tuple
* can get away without filtering
* add comment reasons
* fix
* some review suggestions
* this works (first draft)
* this is better
* script to print platform codes and dates
* sanity check for dates are in correct ecus and platforms
* mypy
* better variable name and comment
* rename
* same
* slightly better name
* subset
* exclude platforms and live car without dates
* consistent
* self explan
* better name
* test to make sure the functions agree
* clean that up
* comment
* we get other responses from queries not in DB, only check any
* not used or typed
old-commit-hash: f788edb6a5c8d3f516076f886fe0d831ee43b580
2 years ago
# If specified and no matches so far, fall back to brand's fuzzy fingerprinting function
config = FW_QUERY_CONFIGS [ brand ]
if not exact_match and not len ( matches ) and config . match_fw_to_car_fuzzy is not None :
matches | = config . match_fw_to_car_fuzzy ( fw_versions_dict )
if len ( matches ) :
return exact_match , matches
return True , set ( )
def get_present_ecus ( logcan , sendcan , num_pandas = 1 ) - > Set [ EcuAddrBusType ] :
params = Params ( )
# queries are split by OBD multiplexing mode
queries : Dict [ bool , List [ List [ EcuAddrBusType ] ] ] = { True : [ ] , False : [ ] }
parallel_queries : Dict [ bool , List [ EcuAddrBusType ] ] = { True : [ ] , False : [ ] }
responses = set ( )
for brand , config , r in REQUESTS :
# Skip query if no panda available
if r . bus > num_pandas * 4 - 1 :
continue
for brand_versions in VERSIONS [ brand ] . values ( ) :
for ecu_type , addr , sub_addr in list ( brand_versions ) + config . extra_ecus :
# Only query ecus in whitelist if whitelist is not empty
if len ( r . whitelist_ecus ) == 0 or ecu_type in r . whitelist_ecus :
a = ( addr , sub_addr , r . bus )
# Build set of queries
if sub_addr is None :
if a not in parallel_queries [ r . obd_multiplexing ] :
parallel_queries [ r . obd_multiplexing ] . append ( a )
else : # subaddresses must be queried one by one
if [ a ] not in queries [ r . obd_multiplexing ] :
queries [ r . obd_multiplexing ] . append ( [ a ] )
# Build set of expected responses to filter
response_addr = uds . get_rx_addr_for_tx_addr ( addr , r . rx_offset )
responses . add ( ( response_addr , sub_addr , r . bus ) )
for obd_multiplexing in queries :
queries [ obd_multiplexing ] . insert ( 0 , parallel_queries [ obd_multiplexing ] )
ecu_responses = set ( )
for obd_multiplexing in queries :
set_obd_multiplexing ( params , obd_multiplexing )
for query in queries [ obd_multiplexing ] :
ecu_responses . update ( get_ecu_addrs ( logcan , sendcan , set ( query ) , responses , timeout = 0.1 ) )
return ecu_responses
def get_brand_ecu_matches ( ecu_rx_addrs ) :
""" Returns dictionary of brands and matches with ECUs in their FW versions """
brand_addrs = get_brand_addrs ( )
brand_matches = { brand : set ( ) for brand , _ , _ in REQUESTS }
brand_rx_offsets = { ( brand , r . rx_offset ) for brand , _ , r in REQUESTS }
for addr , sub_addr , _ in ecu_rx_addrs :
# Since we can't know what request an ecu responded to, add matches for all possible rx offsets
for brand , rx_offset in brand_rx_offsets :
a = ( uds . get_rx_addr_for_tx_addr ( addr , - rx_offset ) , sub_addr )
if a in brand_addrs [ brand ] :
brand_matches [ brand ] . add ( a )
return brand_matches
def set_obd_multiplexing ( params : Params , obd_multiplexing : bool ) :
if params . get_bool ( " ObdMultiplexingEnabled " ) != obd_multiplexing :
cloudlog . warning ( f " Setting OBD multiplexing to { obd_multiplexing } " )
params . remove ( " ObdMultiplexingChanged " )
params . put_bool ( " ObdMultiplexingEnabled " , obd_multiplexing )
params . get_bool ( " ObdMultiplexingChanged " , block = True )
cloudlog . warning ( " OBD multiplexing set successfully " )
def get_fw_versions_ordered ( logcan , sendcan , ecu_rx_addrs , timeout = 0.1 , num_pandas = 1 , debug = False , progress = False ) - > \
List [ capnp . lib . capnp . _DynamicStructBuilder ] :
""" Queries for FW versions ordering brands by likelihood, breaks when exact match is found """
all_car_fw = [ ]
brand_matches = get_brand_ecu_matches ( ecu_rx_addrs )
for brand in sorted ( brand_matches , key = lambda b : len ( brand_matches [ b ] ) , reverse = True ) :
# Skip this brand if there are no matching present ECUs
if not len ( brand_matches [ brand ] ) :
continue
car_fw = get_fw_versions ( logcan , sendcan , query_brand = brand , timeout = timeout , num_pandas = num_pandas , debug = debug , progress = progress )
all_car_fw . extend ( car_fw )
# If there is a match using this brand's FW alone, finish querying early
_ , matches = match_fw_to_car ( car_fw , log = False )
if len ( matches ) == 1 :
break
return all_car_fw
def get_fw_versions ( logcan , sendcan , query_brand = None , extra = None , timeout = 0.1 , num_pandas = 1 , debug = False , progress = False ) - > \
List [ capnp . lib . capnp . _DynamicStructBuilder ] :
versions = VERSIONS . copy ( )
params = Params ( )
if query_brand is not None :
versions = { query_brand : versions [ query_brand ] }
if extra is not None :
versions . update ( extra )
# Extract ECU addresses to query from fingerprints
# ECUs using a subaddress need be queried one by one, the rest can be done in parallel
addrs = [ ]
parallel_addrs = [ ]
ecu_types = { }
for brand , brand_versions in versions . items ( ) :
config = FW_QUERY_CONFIGS [ brand ]
for ecu in brand_versions . values ( ) :
# Each brand can define extra ECUs to query for data collection
for ecu_type , addr , sub_addr in list ( ecu ) + config . extra_ecus :
a = ( brand , addr , sub_addr )
if a not in ecu_types :
ecu_types [ a ] = ecu_type
if sub_addr is None :
if a not in parallel_addrs :
parallel_addrs . append ( a )
else :
if [ a ] not in addrs :
addrs . append ( [ a ] )
addrs . insert ( 0 , parallel_addrs )
# Get versions and build capnp list to put into CarParams
car_fw = [ ]
requests = [ ( brand , config , r ) for brand , config , r in REQUESTS if is_brand ( brand , query_brand ) ]
for addr in tqdm ( addrs , disable = not progress ) :
for addr_chunk in chunks ( addr ) :
for brand , config , r in requests :
# Skip query if no panda available
if r . bus > num_pandas * 4 - 1 :
continue
# Toggle OBD multiplexing for each request
if r . bus % 4 == 1 :
set_obd_multiplexing ( params , r . obd_multiplexing )
try :
query_addrs = [ ( a , s ) for ( b , a , s ) in addr_chunk if b in ( brand , ' any ' ) and
( len ( r . whitelist_ecus ) == 0 or ecu_types [ ( b , a , s ) ] in r . whitelist_ecus ) ]
if query_addrs :
query = IsoTpParallelQuery ( sendcan , logcan , r . bus , query_addrs , r . request , r . response , r . rx_offset , debug = debug )
for ( tx_addr , sub_addr ) , version in query . get_data ( timeout ) . items ( ) :
f = car . CarParams . CarFw . new_message ( )
f . ecu = ecu_types . get ( ( brand , tx_addr , sub_addr ) , Ecu . unknown )
f . fwVersion = version
f . address = tx_addr
f . responseAddress = uds . get_rx_addr_for_tx_addr ( tx_addr , r . rx_offset )
f . request = r . request
f . brand = brand
f . bus = r . bus
f . logging = r . logging or ( f . ecu , tx_addr , sub_addr ) in config . extra_ecus
f . obdMultiplexing = r . obd_multiplexing
if sub_addr is not None :
f . subAddress = sub_addr
car_fw . append ( f )
except Exception :
cloudlog . exception ( " FW query exception " )
return car_fw
if __name__ == " __main__ " :
import time
import argparse
import cereal . messaging as messaging
from selfdrive . car . vin import get_vin
parser = argparse . ArgumentParser ( description = ' Get firmware version of ECUs ' )
parser . add_argument ( ' --scan ' , action = ' store_true ' )
parser . add_argument ( ' --debug ' , action = ' store_true ' )
parser . add_argument ( ' --brand ' , help = ' Only query addresses/with requests for this brand ' )
args = parser . parse_args ( )
logcan = messaging . sub_sock ( ' can ' )
pandaStates_sock = messaging . sub_sock ( ' pandaStates ' )
sendcan = messaging . pub_sock ( ' sendcan ' )
extra : Any = None
if args . scan :
extra = { }
# Honda
for i in range ( 256 ) :
extra [ ( Ecu . unknown , 0x18da00f1 + ( i << 8 ) , None ) ] = [ ]
extra [ ( Ecu . unknown , 0x700 + i , None ) ] = [ ]
extra [ ( Ecu . unknown , 0x750 , i ) ] = [ ]
extra = { " any " : { " debug " : extra } }
time . sleep ( 1. )
num_pandas = len ( messaging . recv_one_retry ( pandaStates_sock ) . pandaStates )
t = time . time ( )
print ( " Getting vin... " )
vin_rx_addr , vin = get_vin ( logcan , sendcan , 1 , retry = 10 , debug = args . debug )
print ( f ' RX: { hex ( vin_rx_addr ) } , VIN: { vin } ' )
print ( f " Getting VIN took { time . time ( ) - t : .3f } s " )
print ( )
t = time . time ( )
fw_vers = get_fw_versions ( logcan , sendcan , query_brand = args . brand , extra = extra , num_pandas = num_pandas , debug = args . debug , progress = True )
_ , candidates = match_fw_to_car ( fw_vers )
print ( )
print ( " Found FW versions " )
print ( " { " )
padding = max ( [ len ( fw . brand ) for fw in fw_vers ] or [ 0 ] )
for version in fw_vers :
subaddr = None if version . subAddress == 0 else hex ( version . subAddress )
print ( f " Brand: { version . brand : { padding } } , bus: { version . bus } - (Ecu. { version . ecu } , { hex ( version . address ) } , { subaddr } ): [ { version . fwVersion } ] " )
print ( " } " )
print ( )
print ( " Possible matches: " , candidates )
print ( f " Getting fw took { time . time ( ) - t : .3f } s " )