From 06aef9edd35b09382fac2616b190816bd8fe9a98 Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Sun, 16 Jul 2023 14:57:44 +0800
Subject: [PATCH] encoder: remove public function `encoder_init`  (#28971)

---
 system/loggerd/encoder/ffmpeg_encoder.cc | 3 ++-
 system/loggerd/encoder/ffmpeg_encoder.h  | 4 +---
 system/loggerd/encoder/v4l_encoder.cc    | 3 ++-
 system/loggerd/encoder/v4l_encoder.h     | 4 +---
 4 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/system/loggerd/encoder/ffmpeg_encoder.cc b/system/loggerd/encoder/ffmpeg_encoder.cc
index 198216114a..26348988ff 100644
--- a/system/loggerd/encoder/ffmpeg_encoder.cc
+++ b/system/loggerd/encoder/ffmpeg_encoder.cc
@@ -24,7 +24,8 @@ extern "C" {
 
 const int env_debug_encoder = (getenv("DEBUG_ENCODER") != NULL) ? atoi(getenv("DEBUG_ENCODER")) : 0;
 
-void FfmpegEncoder::encoder_init() {
+FfmpegEncoder::FfmpegEncoder(const EncoderInfo &encoder_info, int in_width, int in_height)
+    : VideoEncoder(encoder_info, in_width, in_height) {
   frame = av_frame_alloc();
   assert(frame);
   frame->format = AV_PIX_FMT_YUV420P;
diff --git a/system/loggerd/encoder/ffmpeg_encoder.h b/system/loggerd/encoder/ffmpeg_encoder.h
index d3ba18e52c..9e45a3d82d 100644
--- a/system/loggerd/encoder/ffmpeg_encoder.h
+++ b/system/loggerd/encoder/ffmpeg_encoder.h
@@ -16,10 +16,8 @@ extern "C" {
 
 class FfmpegEncoder : public VideoEncoder {
 public:
-  FfmpegEncoder(const EncoderInfo &encoder_info, int in_width, int in_height)
-      : VideoEncoder(encoder_info, in_width, in_height) { encoder_init(); }
+  FfmpegEncoder(const EncoderInfo &encoder_info, int in_width, int in_height);
   ~FfmpegEncoder();
-  void encoder_init();
   int encode_frame(VisionBuf* buf, VisionIpcBufExtra *extra);
   void encoder_open(const char* path);
   void encoder_close();
diff --git a/system/loggerd/encoder/v4l_encoder.cc b/system/loggerd/encoder/v4l_encoder.cc
index 53fb93d834..13dae72d38 100644
--- a/system/loggerd/encoder/v4l_encoder.cc
+++ b/system/loggerd/encoder/v4l_encoder.cc
@@ -131,7 +131,8 @@ void V4LEncoder::dequeue_handler(V4LEncoder *e) {
   }
 }
 
-void V4LEncoder::encoder_init() {
+V4LEncoder::V4LEncoder(const EncoderInfo &encoder_info, int in_width, int in_height)
+    : VideoEncoder(encoder_info, in_width, in_height) {
   fd = open("/dev/v4l/by-path/platform-aa00000.qcom_vidc-video-index1", O_RDWR|O_NONBLOCK);
   assert(fd >= 0);
 
diff --git a/system/loggerd/encoder/v4l_encoder.h b/system/loggerd/encoder/v4l_encoder.h
index bd27838b89..9336bf3d8b 100644
--- a/system/loggerd/encoder/v4l_encoder.h
+++ b/system/loggerd/encoder/v4l_encoder.h
@@ -8,10 +8,8 @@
 
 class V4LEncoder : public VideoEncoder {
 public:
-  V4LEncoder(const EncoderInfo &encoder_info, int in_width, int in_height)
-     : VideoEncoder(encoder_info, in_width, in_height) { encoder_init(); }
+  V4LEncoder(const EncoderInfo &encoder_info, int in_width, int in_height);
   ~V4LEncoder();
-  void encoder_init();
   int encode_frame(VisionBuf* buf, VisionIpcBufExtra *extra);
   void encoder_open(const char* path);
   void encoder_close();