Laikad: Need to understand constellationId to understand clock (#28552)

Need to understand constellationId to understand clock old-commit-hash: 6d25f66cf1
2 years ago · 091964205d
parent cfc79b5e8d
commit 091964205d
1 changed files with 2 additions and 2 deletions
--- a/selfdrive/locationd/laikad.py
+++ b/selfdrive/locationd/laikad.py
@ -196,11 +196,11 @@ class Laikad:
      try:
        constellation_id = ConstellationId.from_qcom_source(gnss_msg.drMeasurementReport.source)
        good_constellation = constellation_id in [ConstellationId.GPS, ConstellationId.SBAS, ConstellationId.GLONASS]
+        report_time = self.gps_time_from_qcom_report(gnss_msg)
      except NotImplementedError:
-        good_constellation = False
+        return False
      # Garbage timestamps with week > 32767 are sometimes sent by module.
      # This is an issue with gpsTime and GLONASS time.
-      report_time = self.gps_time_from_qcom_report(gnss_msg)
      good_week = report_time.week < np.iinfo(np.int16).max
      return good_constellation and good_week
    elif gnss_msg.which() == 'measurementReport' and not self.use_qcom: