[cabana] fix clang17 warning (#30490)

[cabana] Improve signal timing calculation in findsingal.cc

The variables `first_sec` and `last_sec` have been separately initialized first before being used in `std::minmax` for signal timings. This resolves compilation warnings and potential risks of using temporary values of these variables.
old-commit-hash: 2a9986d948
chrysler-long2
DevTekVE 1 year ago committed by GitHub
parent 4f1ed42285
commit 0f985f5d13
  1. 4
      tools/cabana/tools/findsignal.cc

@ -214,7 +214,9 @@ void FindSignalDlg::setInitialSignals() {
sig.factor = factor_edit->text().toDouble();
sig.offset = offset_edit->text().toDouble();
auto [first_sec, last_sec] = std::minmax(first_time_edit->text().toDouble(), last_time_edit->text().toDouble());
double first_time_val = first_time_edit->text().toDouble();
double last_time_val = last_time_edit->text().toDouble();
auto [first_sec, last_sec] = std::minmax(first_time_val, last_time_val);
uint64_t first_time = (can->routeStartTime() + first_sec) * 1e9;
model->last_time = std::numeric_limits<uint64_t>::max();
if (last_sec > 0) {

Loading…
Cancel
Save