From 11b5d51da61cac111fb4e5af3b1df6091d860dfc Mon Sep 17 00:00:00 2001 From: Adeeb Shihadeh Date: Thu, 30 Jun 2022 15:36:40 -0700 Subject: [PATCH] remove mypy ignore from a few scripts --- selfdrive/debug/check_freq.py | 11 +++++++---- selfdrive/debug/check_lag.py | 4 ++-- selfdrive/debug/check_timings.py | 5 +++-- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/selfdrive/debug/check_freq.py b/selfdrive/debug/check_freq.py index 424ad67b6d..b6f3c91bd0 100755 --- a/selfdrive/debug/check_freq.py +++ b/selfdrive/debug/check_freq.py @@ -1,9 +1,9 @@ #!/usr/bin/env python3 -# type: ignore - import argparse import numpy as np from collections import defaultdict, deque +from typing import DefaultDict, Deque + from common.realtime import sec_since_boot import cereal.messaging as messaging @@ -19,8 +19,8 @@ if __name__ == "__main__": socket_names = args.socket sockets = {} - rcv_times = defaultdict(lambda: deque(maxlen=100)) - valids = defaultdict(lambda: deque(maxlen=100)) + rcv_times: DefaultDict[str, Deque[float]] = defaultdict(lambda: deque(maxlen=100)) + valids: DefaultDict[str, Deque[bool]] = defaultdict(lambda: deque(maxlen=100)) t = sec_since_boot() for name in socket_names: @@ -31,6 +31,9 @@ if __name__ == "__main__": while True: for socket in poller.poll(100): msg = messaging.recv_one(socket) + if msg is None: + continue + name = msg.which() t = sec_since_boot() diff --git a/selfdrive/debug/check_lag.py b/selfdrive/debug/check_lag.py index c922642982..141156db91 100755 --- a/selfdrive/debug/check_lag.py +++ b/selfdrive/debug/check_lag.py @@ -1,5 +1,5 @@ #!/usr/bin/env python3 -# type: ignore +from typing import Dict import cereal.messaging as messaging from cereal.services import service_list @@ -10,7 +10,7 @@ TO_CHECK = ['carState'] if __name__ == "__main__": sm = messaging.SubMaster(TO_CHECK) - prev_t = {} + prev_t: Dict[str, float] = {} while True: sm.update() diff --git a/selfdrive/debug/check_timings.py b/selfdrive/debug/check_timings.py index 03e39fd70d..69304f97b5 100755 --- a/selfdrive/debug/check_timings.py +++ b/selfdrive/debug/check_timings.py @@ -1,14 +1,15 @@ #!/usr/bin/env python3 -# type: ignore + import sys import time import numpy as np +from typing import DefaultDict, Deque from collections import defaultdict, deque import cereal.messaging as messaging socks = {s: messaging.sub_sock(s, conflate=False) for s in sys.argv[1:]} -ts = defaultdict(lambda: deque(maxlen=100)) +ts: DefaultDict[str, Deque[float]] = defaultdict(lambda: deque(maxlen=100)) if __name__ == "__main__": while True: