From 15a58247ddd1b3415920ffae404b20daf735067a Mon Sep 17 00:00:00 2001 From: Greg Hogan Date: Wed, 10 Nov 2021 23:27:10 -0800 Subject: [PATCH] profiling: replace pyflame with py-spy (#22864) * py-spy * remove pyflame * find process by name old-commit-hash: caad4919ac74af8d4dd3aede20d3ba05e5e06c67 --- selfdrive/debug/profiling/py-spy/profile.sh | 21 +++++++++++++++++++ selfdrive/debug/profiling/pyflame/build.txt | 3 --- .../debug/profiling/pyflame/fix-aarch64.patch | 3 --- selfdrive/debug/profiling/pyflame/flame.sh | 3 --- .../debug/profiling/pyflame/flamegraph.pl | 3 --- selfdrive/debug/profiling/pyflame/pyflame | 3 --- 6 files changed, 21 insertions(+), 15 deletions(-) create mode 100755 selfdrive/debug/profiling/py-spy/profile.sh delete mode 100644 selfdrive/debug/profiling/pyflame/build.txt delete mode 100644 selfdrive/debug/profiling/pyflame/fix-aarch64.patch delete mode 100755 selfdrive/debug/profiling/pyflame/flame.sh delete mode 100755 selfdrive/debug/profiling/pyflame/flamegraph.pl delete mode 100755 selfdrive/debug/profiling/pyflame/pyflame diff --git a/selfdrive/debug/profiling/py-spy/profile.sh b/selfdrive/debug/profiling/py-spy/profile.sh new file mode 100755 index 0000000000..2fdbe8d16e --- /dev/null +++ b/selfdrive/debug/profiling/py-spy/profile.sh @@ -0,0 +1,21 @@ +#!/usr/bin/env bash +set -e + +cd "$(dirname "$0")" + +# find process with name passed in (excluding this process) +for PID in $(pgrep -f $1); do + if [ "$PID" != "$$" ]; then + ps -p $PID -o args + TRACE_PID=$PID + break + fi +done + +if [ -z "$TRACE_PID" ]; then + echo "could not find PID for $1" + exit 1 +fi + +sudo env PATH=$PATH py-spy record -d 5 -o /tmp/perf$TRACE_PID.svg -p $TRACE_PID && +google-chrome /tmp/perf$TRACE_PID.svg diff --git a/selfdrive/debug/profiling/pyflame/build.txt b/selfdrive/debug/profiling/pyflame/build.txt deleted file mode 100644 index 3320ae522d..0000000000 --- a/selfdrive/debug/profiling/pyflame/build.txt +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:157ca425c4ea68345b5d44356c6fd65d0e32a006e5a0e770c75c7d136dbd0c4c -size 174 diff --git a/selfdrive/debug/profiling/pyflame/fix-aarch64.patch b/selfdrive/debug/profiling/pyflame/fix-aarch64.patch deleted file mode 100644 index 09c6f82071..0000000000 --- a/selfdrive/debug/profiling/pyflame/fix-aarch64.patch +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:7eb044134b9c9fae6152fe8c504810aa8d1dc6027af3157965f87f3431154855 -size 11787 diff --git a/selfdrive/debug/profiling/pyflame/flame.sh b/selfdrive/debug/profiling/pyflame/flame.sh deleted file mode 100755 index ed1ee1b2b5..0000000000 --- a/selfdrive/debug/profiling/pyflame/flame.sh +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:b83b957896775bc93363731be30b12aa232bb77334f379a7e3894de3d53ced03 -size 194 diff --git a/selfdrive/debug/profiling/pyflame/flamegraph.pl b/selfdrive/debug/profiling/pyflame/flamegraph.pl deleted file mode 100755 index dccd3ae789..0000000000 --- a/selfdrive/debug/profiling/pyflame/flamegraph.pl +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:4a373447ce1fed5e37708c689f10e6e852a69f87d3cb9bf36913f15a6fdba0dd -size 34109 diff --git a/selfdrive/debug/profiling/pyflame/pyflame b/selfdrive/debug/profiling/pyflame/pyflame deleted file mode 100755 index b829d6dc9a..0000000000 --- a/selfdrive/debug/profiling/pyflame/pyflame +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:b3a77c355bffcad1e01cbc466e8b7133de4a7411af9a3e1c90610f14f7650298 -size 1757424