From 179f5ac2e7d27ed81515f9a5c90fdb360d0330fd Mon Sep 17 00:00:00 2001 From: Willem Melching Date: Wed, 26 Jan 2022 17:13:32 +0100 Subject: [PATCH] compare_logs: catch typeError (#23632) old-commit-hash: 5ac32705d0b5b461f5f8ef5556679534b5a45e58 --- selfdrive/test/process_replay/compare_logs.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/selfdrive/test/process_replay/compare_logs.py b/selfdrive/test/process_replay/compare_logs.py index 9cf8e3fa9a..de734e52fb 100755 --- a/selfdrive/test/process_replay/compare_logs.py +++ b/selfdrive/test/process_replay/compare_logs.py @@ -85,11 +85,14 @@ def compare_logs(log1, log2, ignore_fields=None, ignore_msgs=None, tolerance=Non # Dictdiffer only supports relative tolerance, we also want to check for absolute # TODO: add this to dictdiffer def outside_tolerance(diff): - if diff[0] == "change": - a, b = diff[2] - finite = math.isfinite(a) and math.isfinite(b) - if finite and isinstance(a, numbers.Number) and isinstance(b, numbers.Number): - return abs(a - b) > max(tolerance, tolerance * max(abs(a), abs(b))) + try: + if diff[0] == "change": + a, b = diff[2] + finite = math.isfinite(a) and math.isfinite(b) + if finite and isinstance(a, numbers.Number) and isinstance(b, numbers.Number): + return abs(a - b) > max(tolerance, tolerance * max(abs(a), abs(b))) + except TypeError: + pass return True dd = list(filter(outside_tolerance, dd))