From 1c201295c75e3f2d37bf0a5061cddd0acc6faf1a Mon Sep 17 00:00:00 2001 From: Justin Newberry Date: Thu, 8 Feb 2024 14:41:56 -0500 Subject: [PATCH] test_navd: parameterize random test (#31376) * parameterized * import * dumb --- selfdrive/manager/test/test_manager.py | 2 +- selfdrive/navd/tests/test_navd.py | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/selfdrive/manager/test/test_manager.py b/selfdrive/manager/test/test_manager.py index 04af87d9c8..1ae94b26a1 100755 --- a/selfdrive/manager/test/test_manager.py +++ b/selfdrive/manager/test/test_manager.py @@ -40,7 +40,7 @@ class TestManager(unittest.TestCase): # TODO: ensure there are blacklisted procs until we have a dedicated test self.assertTrue(len(BLACKLIST_PROCS), "No blacklisted procs to test not_run") - @parameterized.expand(range(10)) + @parameterized.expand([(i,) for i in range(10)]) def test_startup_time(self, index): start = time.monotonic() os.environ['PREPAREONLY'] = '1' diff --git a/selfdrive/navd/tests/test_navd.py b/selfdrive/navd/tests/test_navd.py index e2a5944c2b..014b1a32a1 100755 --- a/selfdrive/navd/tests/test_navd.py +++ b/selfdrive/navd/tests/test_navd.py @@ -4,6 +4,8 @@ import random import unittest import numpy as np +from parameterized import parameterized + import cereal.messaging as messaging from openpilot.common.params import Params from openpilot.selfdrive.manager.process_config import managed_processes @@ -50,11 +52,11 @@ class TestNavd(unittest.TestCase): } self._check_route(start, end) - def test_random(self): - for _ in range(10): - start = {"latitude": random.uniform(-90, 90), "longitude": random.uniform(-180, 180)} - end = {"latitude": random.uniform(-90, 90), "longitude": random.uniform(-180, 180)} - self._check_route(start, end, check_coords=False) + @parameterized.expand([(i,) for i in range(10)]) + def test_random(self, index): + start = {"latitude": random.uniform(-90, 90), "longitude": random.uniform(-180, 180)} + end = {"latitude": random.uniform(-90, 90), "longitude": random.uniform(-180, 180)} + self._check_route(start, end, check_coords=False) if __name__ == "__main__":