From 1e906366f8439e3ef3f4f8fc01e2f2ec0f951a86 Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Sun, 23 Jan 2022 05:49:03 +0800 Subject: [PATCH] ui/setup: check http status code (#23597) * check resp code * always cleanup curl and close file * curl_global_init * space * cleaner * Revert "curl_global_init" This reverts commit c3f1a7cee87804993ce8f5fd5939570a8e9ffd3a. --- selfdrive/ui/qt/setup/setup.cc | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/selfdrive/ui/qt/setup/setup.cc b/selfdrive/ui/qt/setup/setup.cc index bd494327cc..3117eb258d 100644 --- a/selfdrive/ui/qt/setup/setup.cc +++ b/selfdrive/ui/qt/setup/setup.cc @@ -37,15 +37,18 @@ void Setup::download(QString url) { curl_easy_setopt(curl, CURLOPT_USERAGENT, USER_AGENT); int ret = curl_easy_perform(curl); - if (ret != CURLE_OK) { + + long res_status = 0; + curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &res_status); + if (ret == CURLE_OK && res_status == 200) { + rename(tmpfile, "/tmp/installer"); + emit finished(true); + } else { emit finished(false); - return; } + curl_easy_cleanup(curl); fclose(fp); - - rename(tmpfile, "/tmp/installer"); - emit finished(true); } QWidget * Setup::low_voltage() {