From 239b228ca6987daa54c20090346d458c9bd4493d Mon Sep 17 00:00:00 2001 From: Justin Newberry Date: Fri, 5 Jan 2024 16:57:02 -0500 Subject: [PATCH] add the notebook example to car port docs (#30920) * add the notebook example * fix link * add image * no lfs * no lfs --- tools/car_porting/README.md | 10 +++++++++- .../car_porting/examples/subaru_steer_temp_fault.ipynb | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/tools/car_porting/README.md b/tools/car_porting/README.md index 14e6c71e58..ca21cdd329 100644 --- a/tools/car_porting/README.md +++ b/tools/car_porting/README.md @@ -55,4 +55,12 @@ Traceback (most recent call last): File "/home/batman/xx/openpilot/openpilot/selfdrive/car/tests/test_models.py", line 380, in test_panda_safety_carstate self.assertFalse(len(failed_checks), f"panda safety doesn't agree with openpilot: {failed_checks}") AssertionError: 1 is not false : panda safety doesn't agree with openpilot: {'gasPressed': 116} -``` \ No newline at end of file +``` + +### [tools/car_porting/examples/subaru_steer_temp_fault.ipynb](/tools/car_porting/examples/subaru_steer_temp_fault.ipynb) + +An example of searching through a database of segments for a specific condition, and plotting the results. + +![steer warning example](https://github.com/commaai/openpilot/assets/9648890/d60ad120-4b44-4974-ac79-adc660fb8fe2) + +*a plot of the steer_warning vs steering angle, where we can see it is clearly caused by a large steering angle change* diff --git a/tools/car_porting/examples/subaru_steer_temp_fault.ipynb b/tools/car_porting/examples/subaru_steer_temp_fault.ipynb index 9dea025c62..a20d7d5062 100644 --- a/tools/car_porting/examples/subaru_steer_temp_fault.ipynb +++ b/tools/car_porting/examples/subaru_steer_temp_fault.ipynb @@ -6,7 +6,7 @@ "metadata": {}, "outputs": [], "source": [ - "# An example of searching through the database of segments for a specific condition, and plotting the results.\n", + "# An example of searching through a database of segments for a specific condition, and plotting the results.\n", "\n", "segments = [\n", " \"c3d1ccb52f5f9d65|2023-07-22--01-23-20--6\",\n",