diff --git a/selfdrive/ui/qt/offroad/networking.cc b/selfdrive/ui/qt/offroad/networking.cc index 30f65cf9fb..a5af1662f9 100644 --- a/selfdrive/ui/qt/offroad/networking.cc +++ b/selfdrive/ui/qt/offroad/networking.cc @@ -206,9 +206,6 @@ WifiUI::WifiUI(QWidget *parent, WifiManager* wifi) : QWidget(parent), wifi(wifi) void WifiUI::refresh() { clearLayout(main_layout); - connectButtons = new QButtonGroup(this); // TODO check if this is a leak - QObject::connect(connectButtons, qOverload(&QButtonGroup::buttonClicked), this, &WifiUI::handleButton); - int i = 0; for (Network &network : wifi->seen_networks) { QHBoxLayout *hlayout = new QHBoxLayout; @@ -251,10 +248,9 @@ void WifiUI::refresh() { QPushButton* btn = new QPushButton(network.security_type == SecurityType::UNSUPPORTED ? "Unsupported" : (network.connected == ConnectedType::CONNECTED ? "Connected" : (network.connected == ConnectedType::CONNECTING ? "Connecting" : "Connect"))); btn->setDisabled(network.connected == ConnectedType::CONNECTED || network.connected == ConnectedType::CONNECTING || network.security_type == SecurityType::UNSUPPORTED); btn->setFixedWidth(350); - hlayout->addWidget(btn, 0, Qt::AlignRight); - - connectButtons->addButton(btn, i); + QObject::connect(btn, &QPushButton::clicked, this, [=]() { emit connectToNetwork(network); }); + hlayout->addWidget(btn, 0, Qt::AlignRight); main_layout->addLayout(hlayout, 1); // Don't add the last horizontal line if (i+1 < wifi->seen_networks.size()) { @@ -264,9 +260,3 @@ void WifiUI::refresh() { } main_layout->addStretch(3); } - -void WifiUI::handleButton(QAbstractButton* button) { - QPushButton* btn = static_cast(button); - Network n = wifi->seen_networks[connectButtons->id(btn)]; - emit connectToNetwork(n); -} diff --git a/selfdrive/ui/qt/offroad/networking.h b/selfdrive/ui/qt/offroad/networking.h index 22b1ad9a9b..2ca2050ec9 100644 --- a/selfdrive/ui/qt/offroad/networking.h +++ b/selfdrive/ui/qt/offroad/networking.h @@ -30,7 +30,6 @@ private: WifiManager *wifi = nullptr; QVBoxLayout* main_layout; - QButtonGroup *connectButtons; bool tetheringEnabled; signals: @@ -38,7 +37,6 @@ signals: public slots: void refresh(); - void handleButton(QAbstractButton* m_button); }; class AdvancedNetworking : public QWidget {