From 29837b872802db8b445653f63c2c1ab67e7a27af Mon Sep 17 00:00:00 2001
From: Shane Smiskol <shane@smiskol.com>
Date: Tue, 18 Jul 2023 03:43:56 -0700
Subject: [PATCH] IsoTpParallelQuery: log empty responses (#29014)

* check if None

* log instead

* clean up

* should mark done
---
 selfdrive/car/isotp_parallel_query.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/selfdrive/car/isotp_parallel_query.py b/selfdrive/car/isotp_parallel_query.py
index 8ab9728e5f..93033126a0 100644
--- a/selfdrive/car/isotp_parallel_query.py
+++ b/selfdrive/car/isotp_parallel_query.py
@@ -115,7 +115,13 @@ class IsoTpParallelQuery:
           addrs_responded.add(tx_addr)
           response_timeouts[tx_addr] = time.monotonic() + timeout
 
-        if not dat:
+        if dat is None:
+          continue
+
+        # Log unexpected empty responses
+        if len(dat) == 0:
+          cloudlog.error(f"iso-tp query empty response: {tx_addr}")
+          request_done[tx_addr] = True
           continue
 
         counter = request_counter[tx_addr]