From 30ab584d4613bcb12fb0b7cb8c5e7e8f67ac9470 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Thu, 29 Feb 2024 00:40:54 -0800 Subject: [PATCH] some clean up --- selfdrive/car/__init__.py | 4 ---- selfdrive/car/tests/test_docs.py | 7 ------- selfdrive/car/toyota/values.py | 1 - 3 files changed, 12 deletions(-) diff --git a/selfdrive/car/__init__.py b/selfdrive/car/__init__.py index 6d9fb177d4..a5909f71af 100644 --- a/selfdrive/car/__init__.py +++ b/selfdrive/car/__init__.py @@ -291,10 +291,6 @@ class Platforms(str, ReprEnum): member._value_ = platform_config.platform_str return member - @classmethod - def init_configs(cls): - [p.config.init_config() for p in cls] - @classmethod def create_dbc_map(cls) -> dict[str, DbcDict]: return {p: p.config.dbc_dict for p in cls} diff --git a/selfdrive/car/tests/test_docs.py b/selfdrive/car/tests/test_docs.py index 21f7bd2392..0cafb508f7 100755 --- a/selfdrive/car/tests/test_docs.py +++ b/selfdrive/car/tests/test_docs.py @@ -11,7 +11,6 @@ from openpilot.selfdrive.car.docs_definitions import Cable, Column, PartType, St from openpilot.selfdrive.car.honda.values import CAR as HONDA from openpilot.selfdrive.debug.dump_car_info import dump_car_info from openpilot.selfdrive.debug.print_docs_diff import print_car_info_diff -from openpilot.selfdrive.car.values import PLATFORMS class TestCarDocs(unittest.TestCase): @@ -27,12 +26,6 @@ class TestCarDocs(unittest.TestCase): self.assertEqual(generated_cars_md, current_cars_md, "Run selfdrive/car/docs.py to update the compatibility documentation") - def test_platforms(self): - for platform in PLATFORMS.values(): - if hasattr(platform, "config"): - self.assertIsNotNone(platform.config) - self.assertIsNotNone(platform.config.dbc_dict) - def test_docs_diff(self): dump_path = os.path.join(BASEDIR, "selfdrive", "car", "tests", "cars_dump") dump_car_info(dump_path) diff --git a/selfdrive/car/toyota/values.py b/selfdrive/car/toyota/values.py index 721b55c944..00ba05e932 100644 --- a/selfdrive/car/toyota/values.py +++ b/selfdrive/car/toyota/values.py @@ -614,6 +614,5 @@ ANGLE_CONTROL_CAR = CAR.with_flags(ToyotaPlatformFlags.ANGLE_CONTROL) # no resume button press required NO_STOP_TIMER_CAR = CAR.with_flags(ToyotaPlatformFlags.NO_STOP_TIMER) -CAR.init_configs() CAR_INFO = CAR.create_carinfo_map() DBC = CAR.create_dbc_map()