map: set destination marker visibility once (#29444)

set visibility once old-commit-hash: da38aed483
2 years ago · 312d80c877
parent c817cb942d
commit 312d80c877
1 changed files with 2 additions and 2 deletions
--- a/selfdrive/ui/qt/maps/map.cc
+++ b/selfdrive/ui/qt/maps/map.cc
@ -377,8 +377,6 @@ void MapWindow::offroadTransition(bool offroad) {
 }

 void MapWindow::updateDestinationMarker() {
-  m_map->setPaintProperty("pinLayer", "visibility", "none");
-
  auto nav_dest = coordinate_from_param("NavDestination");
  if (nav_dest.has_value()) {
    auto point = coordinate_to_collection(*nav_dest);
@ -388,5 +386,7 @@ void MapWindow::updateDestinationMarker() {
    pinSource["data"] = QVariant::fromValue<QMapbox::Feature>(feature);
    m_map->updateSource("pinSource", pinSource);
    m_map->setPaintProperty("pinLayer", "visibility", "visible");
+  } else {
+    m_map->setPaintProperty("pinLayer", "visibility", "none");
  }
 }