From 3234243c97c7c6bf6fb4bb1298a7fd262e697c04 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Thu, 8 Jun 2023 20:47:55 -0700 Subject: [PATCH] FPv2: add comment about nuance of fuzzy fingerprinting (#28465) add comment describing this nuance of fuzzy fingerprint function --- selfdrive/car/fw_versions.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/selfdrive/car/fw_versions.py b/selfdrive/car/fw_versions.py index ca75ed62e5..bfb65f7a12 100755 --- a/selfdrive/car/fw_versions.py +++ b/selfdrive/car/fw_versions.py @@ -91,6 +91,8 @@ def match_fw_to_car_fuzzy(fw_versions_dict, log=True, exclude=None): elif candidate != candidates[0]: return set() + # Note that it is possible to match to a candidate without all its ECUs being present + # if there are enough matches. FIXME: parameterize this or require all ECUs to exist like exact matching if len(matched_ecus) >= 2: if log: cloudlog.error(f"Fingerprinted {candidate} using fuzzy match. {len(matched_ecus)} matching ECUs")