sadmen
/
openpilot_comma
mirror of https://github.com/commaai/openpilot.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

experiment with dates

Browse Source
pull/28386/head
Shane Smiskol 2 years ago
parent f5c752abfd
commit 3251b9cc5c
1 changed files with 115 additions and 85 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 200
      selfdrive/car/hyundai/tests/test_hyundai.py

200
selfdrive/car/hyundai/tests/test_hyundai.py
Unescape View File

@ -1,6 +1,8 @@
#!/usr/bin/env python3 #!/usr/bin/env python3
import re
from collections import defaultdict from collections import defaultdict
import unittest import unittest
import datetime
from cereal import car from cereal import car
from selfdrive.car.hyundai.values import CAR, CANFD_CAR, FW_QUERY_CONFIG, FW_VERSIONS, CAN_GEARS, LEGACY_SAFETY_MODE_CAR, CHECKSUM, CAMERA_SCC_CAR from selfdrive.car.hyundai.values import CAR, CANFD_CAR, FW_QUERY_CONFIG, FW_VERSIONS, CAN_GEARS, LEGACY_SAFETY_MODE_CAR, CHECKSUM, CAMERA_SCC_CAR
@ -10,95 +12,123 @@ ECU_NAME = {v: k for k, v in Ecu.schema.enumerants.items()}
class TestHyundaiFingerprint(unittest.TestCase): class TestHyundaiFingerprint(unittest.TestCase):
def test_canfd_not_in_can_features(self): # def test_canfd_not_in_can_features(self):
can_specific_feature_list = set.union(*CAN_GEARS.values(), *CHECKSUM.values(), LEGACY_SAFETY_MODE_CAR, CAMERA_SCC_CAR) # can_specific_feature_list = set.union(*CAN_GEARS.values(), *CHECKSUM.values(), LEGACY_SAFETY_MODE_CAR, CAMERA_SCC_CAR)
for car_model in CANFD_CAR: # for car_model in CANFD_CAR:
self.assertNotIn(car_model, can_specific_feature_list, "CAN FD car unexpectedly found in a CAN feature list") # self.assertNotIn(car_model, can_specific_feature_list, "CAN FD car unexpectedly found in a CAN feature list")
#
def test_auxiliary_request_ecu_whitelist(self): # def test_auxiliary_request_ecu_whitelist(self):
# Asserts only auxiliary Ecus can exist in database for CAN-FD cars # # Asserts only auxiliary Ecus can exist in database for CAN-FD cars
whitelisted_ecus = {ecu for r in FW_QUERY_CONFIG.requests for ecu in r.whitelist_ecus if r.auxiliary} # whitelisted_ecus = {ecu for r in FW_QUERY_CONFIG.requests for ecu in r.whitelist_ecus if r.auxiliary}
#
for car_model in CANFD_CAR: # for car_model in CANFD_CAR:
ecus = {fw[0] for fw in FW_VERSIONS[car_model].keys()} # ecus = {fw[0] for fw in FW_VERSIONS[car_model].keys()}
ecus_not_in_whitelist = ecus - whitelisted_ecus # ecus_not_in_whitelist = ecus - whitelisted_ecus
ecu_strings = ", ".join([f'Ecu.{ECU_NAME[ecu]}' for ecu in ecus_not_in_whitelist]) # ecu_strings = ", ".join([f'Ecu.{ECU_NAME[ecu]}' for ecu in ecus_not_in_whitelist])
self.assertEqual(len(ecus_not_in_whitelist), 0, f'{car_model}: Car model has ECUs not in auxiliary request whitelists: {ecu_strings}') # self.assertEqual(len(ecus_not_in_whitelist), 0, f'{car_model}: Car model has ECUs not in auxiliary request whitelists: {ecu_strings}')
#
def test_certain_ecus_available(self): # def test_certain_ecus_available(self):
# Asserts certain ecu keys essential for fuzzy fingerprinting are available on all platforms # # Asserts certain ecu keys essential for fuzzy fingerprinting are available on all platforms
for car, ecus in FW_VERSIONS.items(): # for car, ecus in FW_VERSIONS.items():
for essential_ecu in FW_QUERY_CONFIG.fuzzy_ecus: # for essential_ecu in FW_QUERY_CONFIG.fuzzy_ecus:
with self.subTest(car=car): # with self.subTest(car=car):
if car == CAR.HYUNDAI_GENESIS: # if car == CAR.HYUNDAI_GENESIS:
raise unittest.SkipTest # raise unittest.SkipTest
self.assertIn(essential_ecu, [e[0] for e in ecus]) # self.assertIn(essential_ecu, [e[0] for e in ecus])
#
def test_fuzzy_platform_codes(self): # def test_fuzzy_platform_codes(self):
codes = FW_QUERY_CONFIG.fuzzy_get_platform_codes([b'\xf1\x00DH LKAS 1.1 -150210']) # codes = FW_QUERY_CONFIG.fuzzy_get_platform_codes([b'\xf1\x00DH LKAS 1.1 -150210'])
self.assertEqual(codes, {b"DH"}) # self.assertEqual(codes, {b"DH"})
#
codes = FW_QUERY_CONFIG.fuzzy_get_platform_codes([b'\xf1\x00AEhe SCC H-CUP 1.01 1.01 96400-G2000 ']) # codes = FW_QUERY_CONFIG.fuzzy_get_platform_codes([b'\xf1\x00AEhe SCC H-CUP 1.01 1.01 96400-G2000 '])
self.assertEqual(codes, {b"AEhe"}) # self.assertEqual(codes, {b"AEhe"})
#
codes = FW_QUERY_CONFIG.fuzzy_get_platform_codes([b'\xf1\x00CV1_ RDR ----- 1.00 1.01 99110-CV000 ']) # codes = FW_QUERY_CONFIG.fuzzy_get_platform_codes([b'\xf1\x00CV1_ RDR ----- 1.00 1.01 99110-CV000 '])
self.assertEqual(codes, {b"CV1"}) # self.assertEqual(codes, {b"CV1"})
#
codes = FW_QUERY_CONFIG.fuzzy_get_platform_codes([ # codes = FW_QUERY_CONFIG.fuzzy_get_platform_codes([
b'\xf1\x00DH LKAS 1.1 -150210', # b'\xf1\x00DH LKAS 1.1 -150210',
b'\xf1\x00AEhe SCC H-CUP 1.01 1.01 96400-G2000 ', # b'\xf1\x00AEhe SCC H-CUP 1.01 1.01 96400-G2000 ',
b'\xf1\x00CV1_ RDR ----- 1.00 1.01 99110-CV000 ', # b'\xf1\x00CV1_ RDR ----- 1.00 1.01 99110-CV000 ',
]) # ])
self.assertEqual(codes, {b"DH", b"AEhe", b"CV1"}) # self.assertEqual(codes, {b"DH", b"AEhe", b"CV1"})
#
def test_excluded_platforms(self): # def test_excluded_platforms(self):
# Asserts a list of platforms that will not fuzzy fingerprint due to shared platform codes # # Asserts a list of platforms that will not fuzzy fingerprint due to shared platform codes
# This list can be shrunk as we combine platforms and detect features # # This list can be shrunk as we combine platforms and detect features
excluded_platforms = [ # excluded_platforms = [
CAR.HYUNDAI_GENESIS, # CAR.HYUNDAI_GENESIS,
CAR.IONIQ, # CAR.IONIQ,
CAR.IONIQ_PHEV_2019, # CAR.IONIQ_PHEV_2019,
CAR.IONIQ_PHEV, # CAR.IONIQ_PHEV,
CAR.IONIQ_EV_2020, # CAR.IONIQ_EV_2020,
CAR.IONIQ_EV_LTD, # CAR.IONIQ_EV_LTD,
CAR.IONIQ_HEV_2022, # CAR.IONIQ_HEV_2022,
CAR.SANTA_FE, # CAR.SANTA_FE,
CAR.SANTA_FE_2022, # CAR.SANTA_FE_2022,
CAR.KIA_STINGER, # CAR.KIA_STINGER,
CAR.KIA_STINGER_2022, # CAR.KIA_STINGER_2022,
CAR.GENESIS_G70, # CAR.GENESIS_G70,
CAR.GENESIS_G70_2020, # CAR.GENESIS_G70_2020,
CAR.TUCSON_4TH_GEN, # CAR.TUCSON_4TH_GEN,
CAR.TUCSON_HYBRID_4TH_GEN, # CAR.TUCSON_HYBRID_4TH_GEN,
CAR.KIA_SPORTAGE_HYBRID_5TH_GEN, # CAR.KIA_SPORTAGE_HYBRID_5TH_GEN,
CAR.SANTA_CRUZ_1ST_GEN, # CAR.SANTA_CRUZ_1ST_GEN,
CAR.KIA_SPORTAGE_5TH_GEN, # CAR.KIA_SPORTAGE_5TH_GEN,
] # ]
#
all_platform_codes = defaultdict(set) # all_platform_codes = defaultdict(set)
# for candidate, fw_by_addr in FW_VERSIONS.items():
# for addr, fws in fw_by_addr.items():
# if addr[0] not in FW_QUERY_CONFIG.fuzzy_ecus:
# continue
#
# for platform_code in FW_QUERY_CONFIG.fuzzy_get_platform_codes(fws):
# all_platform_codes[(addr[1], addr[2], platform_code)].add(candidate)
#
# platforms_with_shared_codes = []
# for platform, fw_by_addr in FW_VERSIONS.items():
# shared_codes = []
# for addr, fws in fw_by_addr.items():
# if addr[0] not in FW_QUERY_CONFIG.fuzzy_ecus:
# continue
#
# for f in fws:
# platform_code = list(FW_QUERY_CONFIG.fuzzy_get_platform_codes([f]))[0]
# shared_codes.append(len(all_platform_codes[(addr[1], addr[2], platform_code)]) > 1)
#
# if all(shared_codes):
# platforms_with_shared_codes.append(platform)
#
# self.assertEqual(set(platforms_with_shared_codes), set(excluded_platforms))
def test_fw_dates(self):
# format is yymmdd, want to group the year month day
# date_pattern = re.compile(br'(\d\d)(\d\d)(\d\d)')
date_pattern = re.compile(b'[0-9]{6}')
for candidate, fw_by_addr in FW_VERSIONS.items(): for candidate, fw_by_addr in FW_VERSIONS.items():
print(candidate)
for addr, fws in fw_by_addr.items(): for addr, fws in fw_by_addr.items():
if addr[0] not in FW_QUERY_CONFIG.fuzzy_ecus: if addr[0] not in FW_QUERY_CONFIG.fuzzy_ecus:
continue continue
dates = []
for platform_code in FW_QUERY_CONFIG.fuzzy_get_platform_codes(fws): for fw in fws:
all_platform_codes[(addr[1], addr[2], platform_code)].add(candidate) date = date_pattern.search(fw)
if date is not None:
platforms_with_shared_codes = [] dates.append(datetime.datetime.strptime(date.group().decode(), '%y%m%d'))
for platform, fw_by_addr in FW_VERSIONS.items(): print(date.group(), dates[-1])
shared_codes = [] # print(date)
for addr, fws in fw_by_addr.items(): # print(addr, fw, date_pattern.findall(fw))
if addr[0] not in FW_QUERY_CONFIG.fuzzy_ecus: if len(dates) > 1:
continue print('dates', dates)
range_dates = []
for f in fws: cur_date = min(dates)
platform_code = list(FW_QUERY_CONFIG.fuzzy_get_platform_codes([f]))[0] while cur_date < max(dates):
shared_codes.append(len(all_platform_codes[(addr[1], addr[2], platform_code)]) > 1) range_dates.append(cur_date)
cur_date += datetime.timedelta(days=1)
if all(shared_codes): print('total dates', len(range_dates))
platforms_with_shared_codes.append(platform)
print()
self.assertEqual(set(platforms_with_shared_codes), set(excluded_platforms))
if __name__ == "__main__": if __name__ == "__main__":

Write Preview
Loading…
Cancel
Save