From 33952d0a602e45c2b7d1c6e4386d340625a5bcbf Mon Sep 17 00:00:00 2001
From: Mauricio Alvarez Leon <65101411+BBBmau@users.noreply.github.com>
Date: Sat, 28 Sep 2024 13:21:48 -0700
Subject: [PATCH] `ui`: auto-expand summary when diff is present. (#33668)

* ui: use details open when diff is present

* remove comment
---
 .github/workflows/ui_preview.yaml | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ui_preview.yaml b/.github/workflows/ui_preview.yaml
index a2033f8180..24956516f8 100644
--- a/.github/workflows/ui_preview.yaml
+++ b/.github/workflows/ui_preview.yaml
@@ -88,14 +88,15 @@ jobs:
           A=($scenes)
 
           DIFF=""
-          TABLE="<details>"
-          TABLE="${TABLE}<summary>All Screenshots</summary>"
+          open=false
+          TABLE="<summary>All Screenshots</summary>"
           TABLE="${TABLE}<table>"
 
           for ((i=0; i<${#A[*]}; i=i+1));
           do
 
             if ! compare -fuzz 2% -highlight-color DeepSkyBlue1 -lowlight-color Black -compose Src ${{ github.workspace }}/master_ui/${A[$i]}.png ${{ github.workspace }}/pr_ui/${A[$i]}.png ${{ github.workspace }}/pr_ui/${A[$i]}_diff.png; then
+              open=true
               convert ${{ github.workspace }}/pr_ui/${A[$i]}_diff.png -transparent black mask.png
               composite mask.png ${{ github.workspace }}/master_ui/${A[$i]}.png composite_diff.png
               convert -delay 20 ${{ github.workspace }}/master_ui/${A[$i]}.png composite_diff.png -loop 0 ${{ github.workspace }}/pr_ui/${A[$i]}_diff.gif
@@ -134,7 +135,11 @@ jobs:
 
           TABLE="${TABLE}</table>"
           TABLE="${TABLE}</details>"
-
+          if open; then
+            TABLE="<details open>${TABLE}"
+          else
+            TABLE="<details>${TABLE}"
+          fi
           echo "DIFF=$DIFF$TABLE" >> "$GITHUB_OUTPUT"
 
       - name: Saving proposed ui