fix(clip): ignore unknown Params keys (#35226)

* fix: ignore params configured by forks

* comment

* dont bother logging count or in normal flow

* better log
vff-driving
Trey Moen 7 days ago committed by GitHub
parent e8394a27d7
commit 33c164629f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 10
      tools/clip/run.py

@ -16,7 +16,7 @@ from typing import Literal
from cereal.messaging import SubMaster from cereal.messaging import SubMaster
from openpilot.common.basedir import BASEDIR from openpilot.common.basedir import BASEDIR
from openpilot.common.params import Params from openpilot.common.params import Params, UnknownKeyName
from openpilot.common.prefix import OpenpilotPrefix from openpilot.common.prefix import OpenpilotPrefix
from openpilot.tools.lib.route import Route from openpilot.tools.lib.route import Route
from openpilot.tools.lib.logreader import LogReader, ReadMode, comma_api_source from openpilot.tools.lib.logreader import LogReader, ReadMode, comma_api_source
@ -126,8 +126,12 @@ def populate_car_params(route: Route):
entries = init_data.params.entries entries = init_data.params.entries
for cp in entries: for cp in entries:
key, value = cp.key, cp.value key, value = cp.key, cp.value
params.put(key, value) try:
logger.info(f'persisted {len(entries)} CarParam(s)') params.put(key, value)
except UnknownKeyName:
# forks of openpilot may have other Params keys configured. ignore these
logger.warning(f"unknown Params key '{key}', skipping")
logger.debug('persisted CarParams')
def start_proc(args: list[str], env: dict[str, str]): def start_proc(args: list[str], env: dict[str, str]):

Loading…
Cancel
Save