From 34138d0be9b9b0041dc5e15b81c4f4b9e653a9f3 Mon Sep 17 00:00:00 2001 From: Adeeb Shihadeh Date: Wed, 21 Feb 2024 13:57:29 -0800 Subject: [PATCH] qcomgpsd: use AT helper with retry for all AT commands (#31532) --- system/qcomgpsd/qcomgpsd.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/system/qcomgpsd/qcomgpsd.py b/system/qcomgpsd/qcomgpsd.py index 3f72350234..e2a180df86 100755 --- a/system/qcomgpsd/qcomgpsd.py +++ b/system/qcomgpsd/qcomgpsd.py @@ -94,11 +94,7 @@ def at_cmd(cmd: str) -> Optional[str]: return subprocess.check_output(f"mmcli -m any --timeout 30 --command='{cmd}'", shell=True, encoding='utf8') def gps_enabled() -> bool: - try: - p = subprocess.check_output("mmcli -m any --command=\"AT+QGPS?\"", shell=True) - return b"QGPS: 1" in p - except subprocess.CalledProcessError as exc: - raise Exception("failed to execute QGPS mmcli command") from exc + return "QGPS: 1" in at_cmd("AT+QGPS?") def download_assistance(): try: