sadmen
/
openpilot_comma
mirror of https://github.com/commaai/openpilot.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

camerad: pass std::vector by const reference (#34206)

Browse Source 
pass std::vector by const reference
pull/34217/head
Dean Lee 5 months ago committed by GitHub
parent 7202c5acb8
commit 3a6db78601
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 4
      system/camerad/cameras/cdm.cc
  2. 4
      system/camerad/cameras/cdm.h

4
system/camerad/cameras/cdm.cc
Unescape View File

@ -14,7 +14,7 @@ int write_dmi(uint8_t *dst, uint64_t *addr, uint32_t length, uint32_t dmi_addr,
return sizeof(struct cdm_dmi_cmd); return sizeof(struct cdm_dmi_cmd);
} }
int write_cont(uint8_t *dst, uint32_t reg, std::vector<uint32_t> vals) { int write_cont(uint8_t *dst, uint32_t reg, const std::vector<uint32_t> &vals) {
struct cdm_regcontinuous_cmd *cmd = (struct cdm_regcontinuous_cmd*)dst; struct cdm_regcontinuous_cmd *cmd = (struct cdm_regcontinuous_cmd*)dst;
cmd->cmd = CAM_CDM_CMD_REG_CONT; cmd->cmd = CAM_CDM_CMD_REG_CONT;
cmd->count = vals.size(); cmd->count = vals.size();
@ -31,7 +31,7 @@ int write_cont(uint8_t *dst, uint32_t reg, std::vector<uint32_t> vals) {
return sizeof(struct cdm_regcontinuous_cmd) + vals.size()*sizeof(uint32_t); return sizeof(struct cdm_regcontinuous_cmd) + vals.size()*sizeof(uint32_t);
} }
int write_random(uint8_t *dst, std::vector<uint32_t> vals) { int write_random(uint8_t *dst, const std::vector<uint32_t> &vals) {
struct cdm_regrandom_cmd *cmd = (struct cdm_regrandom_cmd*)dst; struct cdm_regrandom_cmd *cmd = (struct cdm_regrandom_cmd*)dst;
cmd->cmd = CAM_CDM_CMD_REG_RANDOM; cmd->cmd = CAM_CDM_CMD_REG_RANDOM;
cmd->count = vals.size() / 2; cmd->count = vals.size() / 2;

4
system/camerad/cameras/cdm.h
Unescape View File

@ -7,8 +7,8 @@
#include <memory> #include <memory>
// our helpers // our helpers
int write_random(uint8_t *dst, std::vector<uint32_t> vals); int write_random(uint8_t *dst, const std::vector<uint32_t> &vals);
int write_cont(uint8_t *dst, uint32_t reg, std::vector<uint32_t> vals); int write_cont(uint8_t *dst, uint32_t reg, const std::vector<uint32_t> &vals);
int write_dmi(uint8_t *dst, uint64_t *addr, uint32_t length, uint32_t dmi_addr, uint8_t sel); int write_dmi(uint8_t *dst, uint64_t *addr, uint32_t length, uint32_t dmi_addr, uint8_t sel);
// from drivers/media/platform/msm/camera/cam_cdm/cam_cdm_util.{c,h} // from drivers/media/platform/msm/camera/cam_cdm/cam_cdm_util.{c,h}

Write Preview
Loading…
Cancel
Save