Update contributing (#30705)

* update

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

docs/CONTRIBUTING.md

@@ -1,26 +1,46 @@
 # How to contribute
 
-Our software is open source so you can solve your own problems without needing help from others. And if you solve a problem and are so kind, you can upstream it for the rest of the world to use. Check out our [post about externalization](https://blog.comma.ai/a-2020-theme-externalization/).
-
-Most open source development activity is coordinated through our [GitHub Discussions](https://github.com/commaai/openpilot/discussions) and [Discord](https://discord.comma.ai). A lot of documentation is available at https://docs.comma.ai and on our [blog](https://blog.comma.ai/).
+Our software is open source so you can solve your own problems without needing help from others. And if you solve a problem and are so kind, you can upstream it for the rest of the world to use. Check out our [post about externalization](https://blog.comma.ai/a-2020-theme-externalization/). Development activity is coordinated through our GitHub Issues, [GitHub Discussions](https://github.com/commaai/openpilot/discussions), and [Discord](https://discord.comma.ai).
 
 ### Getting Started
 
- * Setup your [development environment](../tools/)
- * Join our [Discord](https://discord.comma.ai)
- * Make sure you have a [GitHub account](https://github.com/signup/free)
- * Fork [our repositories](https://github.com/commaai) on GitHub
+* Setup your [development environment](../tools/)
+* Read about the [development workflow](WORKFLOW.md)
+* Join our [Discord](https://discord.comma.ai)
+* Docs are at https://docs.comma.ai and https://blog.comma.ai
+
+### What contributions are we looking for?
+
+**openpilot's priorities are [safety](SAFETY.md), stability, quality, and features, in that order.** openpilot is part of comma's mission to *solve self-driving cars while delivering shippable intermediaries*, and all developoment is towards that goal.
+
+The probability of a pull request being merged is a function of its value to the project and the effort it will take us to get it merged.
+If a PR offers *some* value but will take lots of time to get merged, it will be closed.
+Simple, well-tested bug fixes are the easiest to merge, and new features are the hardest to get merged. 
+
+All of these are examples of good PRs:
+* typo fix: https://github.com/commaai/openpilot/pull/30678
+* removing unused code: https://github.com/commaai/openpilot/pull/30573
+* simple car model port: https://github.com/commaai/openpilot/pull/30245
+* car brand port: https://github.com/commaai/openpilot/pull/23331
+
+### What doesn't get merged?
+
+* arbitrary style changes
+* PRs without a clear goal
+* 500+ line PRs: it should be either cleaned up, broken up into smaller PRs, or both
 
 ### First contribution
-Try out some of these first pull requests ideas to dive into the codebase:
 
-* Increase our [mypy](http://mypy-lang.org/) coverage
-* Write some documentation
-* Tackle an open [good first issue](https://github.com/commaai/openpilot/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
+Check out any [good first issue](https://github.com/commaai/openpilot/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) to get started.
+
+### What do I need to contribute?
+
+A lot of openpilot work requires only a PC, and some requires a comma device.
+Most car-related contributions require access to that car, plus a comma device installed in the car.
 
 ## Pull Requests
 
-Pull requests should be against the master branch. Welcomed contributions include bug reports, car ports, and any [open issue](https://github.com/commaai/openpilot/issues). If you're unsure about a contribution, feel free to open a discussion, issue, or draft PR to discuss the problem you're trying to solve.
+Pull requests should be against the master branch. If you're unsure about a contribution, feel free to open a discussion, issue, or draft PR to discuss the problem you're trying to solve.
 
 A good pull request has all of the following:
 * a clearly stated purpose
@@ -37,4 +57,10 @@ We've released a [Model Port guide](https://blog.comma.ai/openpilot-port-guide-f
 
 If you port openpilot to a substantially new car brand, see this more generic [Brand Port guide](https://blog.comma.ai/how-to-write-a-car-port-for-openpilot/).
 
+## Contributing without Code
 
+* Report bugs in GitHub issues.
+* Report driving issues in the `#driving-feedback` Discord channel.
+* Consider opting into driver camera uploads to improve the driver monitoring model.
+* Connect your device to Wi-Fi regularly, so that we can pull data for training better driving models.
+* Run the `nightly` branch and report issues. This branch is like `master` but it's built just like a release.