From 3b9197ffc4fa69f09064fe0f6b5bd51ec2d6b5ab Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Fri, 26 Aug 2022 04:13:38 +0800 Subject: [PATCH] getTextRect: pass text by const reference (#25555) old-commit-hash: 3bb2b4df498ef925b9b5e39cc72ed53143ac63a6 --- selfdrive/ui/qt/util.cc | 2 +- selfdrive/ui/qt/util.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/selfdrive/ui/qt/util.cc b/selfdrive/ui/qt/util.cc index 4be88aaf11..c5697c1045 100644 --- a/selfdrive/ui/qt/util.cc +++ b/selfdrive/ui/qt/util.cc @@ -162,7 +162,7 @@ QPixmap loadPixmap(const QString &fileName, const QSize &size, Qt::AspectRatioMo } } -QRect getTextRect(QPainter &p, int flags, QString text) { +QRect getTextRect(QPainter &p, int flags, const QString &text) { QFontMetrics fm(p.font()); QRect init_rect = fm.boundingRect(text); return fm.boundingRect(init_rect, flags, text); diff --git a/selfdrive/ui/qt/util.h b/selfdrive/ui/qt/util.h index f0e57526c8..209f051963 100644 --- a/selfdrive/ui/qt/util.h +++ b/selfdrive/ui/qt/util.h @@ -24,6 +24,6 @@ void initApp(int argc, char *argv[]); QWidget* topWidget (QWidget* widget); QPixmap loadPixmap(const QString &fileName, const QSize &size = {}, Qt::AspectRatioMode aspectRatioMode = Qt::KeepAspectRatio); -QRect getTextRect(QPainter &p, int flags, QString text); +QRect getTextRect(QPainter &p, int flags, const QString &text); void drawRoundedRect(QPainter &painter, const QRectF &rect, qreal xRadiusTop, qreal yRadiusTop, qreal xRadiusBottom, qreal yRadiusBottom); QColor interpColor(float xv, std::vector xp, std::vector fp);