From 3e190435e387a8f787f829ddf3282e6e948b45f4 Mon Sep 17 00:00:00 2001 From: iejMac <61431446+iejMac@users.noreply.github.com> Date: Mon, 29 Mar 2021 16:32:04 -0700 Subject: [PATCH] settings scrolling improvement (#20525) * no overshoot * removing line Co-authored-by: Comma Device --- selfdrive/ui/qt/offroad/settings.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/selfdrive/ui/qt/offroad/settings.cc b/selfdrive/ui/qt/offroad/settings.cc index a9d18d4aff..8abaeb7ba8 100644 --- a/selfdrive/ui/qt/offroad/settings.cc +++ b/selfdrive/ui/qt/offroad/settings.cc @@ -277,12 +277,13 @@ SettingsWindow::SettingsWindow(QWidget *parent) : QFrame(parent) { panel_frame->setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff); panel_frame->setStyleSheet("background-color:transparent;"); - QScroller *scroller = QScroller::scroller(panel_frame); + QScroller *scroller = QScroller::scroller(panel_frame->viewport()); auto sp = scroller->scrollerProperties(); - sp.setScrollMetric(QScrollerProperties::FrameRate, QVariant::fromValue(QScrollerProperties::Fps30)); + sp.setScrollMetric(QScrollerProperties::VerticalOvershootPolicy, QVariant::fromValue(QScrollerProperties::OvershootAlwaysOff)); - scroller->setScrollerProperties(sp); + scroller->grabGesture(panel_frame->viewport(), QScroller::LeftMouseButtonGesture); + scroller->setScrollerProperties(sp); panel_widget->addWidget(panel_frame);