Networking: Only refresh when visible (#21445)

* only refresh when visible

* catch other case
pull/21447/head
sshane 4 years ago committed by GitHub
parent a74b9dc94f
commit 4000d4a8d2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 5
      selfdrive/ui/qt/offroad/wifiManager.cc

@ -112,7 +112,6 @@ void WifiManager::refreshNetworks() {
seen_ssids.push_back(network.ssid); seen_ssids.push_back(network.ssid);
seen_networks.push_back(network); seen_networks.push_back(network);
} }
} }
QString WifiManager::get_ipv4_address() { QString WifiManager::get_ipv4_address() {
@ -375,10 +374,12 @@ void WifiManager::stateChange(unsigned int new_state, unsigned int previous_stat
emit wrongPassword(connecting_to_network); emit wrongPassword(connecting_to_network);
} else if (new_state == state_connected) { } else if (new_state == state_connected) {
connecting_to_network = ""; connecting_to_network = "";
if (this->isVisible()) {
refreshNetworks(); refreshNetworks();
emit refreshSignal(); emit refreshSignal();
} }
} }
}
// https://developer.gnome.org/NetworkManager/stable/gdbus-org.freedesktop.NetworkManager.Device.Wireless.html // https://developer.gnome.org/NetworkManager/stable/gdbus-org.freedesktop.NetworkManager.Device.Wireless.html
void WifiManager::propertyChange(const QString &interface, const QVariantMap &props, const QStringList &invalidated_props) { void WifiManager::propertyChange(const QString &interface, const QVariantMap &props, const QStringList &invalidated_props) {
@ -386,10 +387,12 @@ void WifiManager::propertyChange(const QString &interface, const QVariantMap &pr
if (knownConnections.isEmpty()) { if (knownConnections.isEmpty()) {
knownConnections = listConnections(); knownConnections = listConnections();
} }
if (this->isVisible()) {
refreshNetworks(); // TODO: only refresh on first scan, then use AccessPointAdded and Removed signals refreshNetworks(); // TODO: only refresh on first scan, then use AccessPointAdded and Removed signals
emit refreshSignal(); emit refreshSignal();
} }
} }
}
void WifiManager::connectionRemoved(const QDBusObjectPath &path) { void WifiManager::connectionRemoved(const QDBusObjectPath &path) {
knownConnections.remove(path); knownConnections.remove(path);

Loading…
Cancel
Save