From 40f37482c3ba1b7ed2868dc447a068903cf11b5e Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Sun, 28 May 2023 05:04:43 +0800 Subject: [PATCH] cabana: fix broken message filtering (#28319) fix message filtering old-commit-hash: b0120e30a491bad0284f860e81064d142519e647 --- tools/cabana/messageswidget.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/cabana/messageswidget.cc b/tools/cabana/messageswidget.cc index 657743901e..e24e8ab291 100644 --- a/tools/cabana/messageswidget.cc +++ b/tools/cabana/messageswidget.cc @@ -254,9 +254,13 @@ static bool parseRange(const QString &filter, uint32_t value, int base = 10) { unsigned int min = std::numeric_limits::min(); unsigned int max = std::numeric_limits::max(); auto s = filter.split('-'); - bool ok = s.size() <= 2; + bool ok = s.size() >= 1 && s.size() <= 2; if (ok && !s[0].isEmpty()) min = s[0].toUInt(&ok, base); - if (ok && s.size() == 2 && !s[1].isEmpty()) max = s[1].toUInt(&ok, base); + if (ok && s.size() == 1) { + max = min; + } else if (ok && s.size() == 2 && !s[1].isEmpty()) { + max = s[1].toUInt(&ok, base); + } return ok && value >= min && value <= max; }