cabana: fix broken message filtering (#28319)

fix message filtering
old-commit-hash: b0120e30a4
beeps
Dean Lee 2 years ago committed by GitHub
parent 3ead794728
commit 40f37482c3
  1. 8
      tools/cabana/messageswidget.cc

@ -254,9 +254,13 @@ static bool parseRange(const QString &filter, uint32_t value, int base = 10) {
unsigned int min = std::numeric_limits<unsigned int>::min(); unsigned int min = std::numeric_limits<unsigned int>::min();
unsigned int max = std::numeric_limits<unsigned int>::max(); unsigned int max = std::numeric_limits<unsigned int>::max();
auto s = filter.split('-'); auto s = filter.split('-');
bool ok = s.size() <= 2; bool ok = s.size() >= 1 && s.size() <= 2;
if (ok && !s[0].isEmpty()) min = s[0].toUInt(&ok, base); if (ok && !s[0].isEmpty()) min = s[0].toUInt(&ok, base);
if (ok && s.size() == 2 && !s[1].isEmpty()) max = s[1].toUInt(&ok, base); if (ok && s.size() == 1) {
max = min;
} else if (ok && s.size() == 2 && !s[1].isEmpty()) {
max = s[1].toUInt(&ok, base);
}
return ok && value >= min && value <= max; return ok && value >= min && value <= max;
} }

Loading…
Cancel
Save