From 41c117bba04ea5850f4221c43e09b24f23b0f3ae Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Fri, 29 Jan 2021 03:35:38 +0800
Subject: [PATCH] keyboard.cc: get value by reference in ranged based loop
 (#19950)

old-commit-hash: a48ab6130c857fce15a5266af93ca5689cc207a4
---
 selfdrive/ui/qt/widgets/keyboard.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/selfdrive/ui/qt/widgets/keyboard.cc b/selfdrive/ui/qt/widgets/keyboard.cc
index 75f655ca4d..7be45945e6 100644
--- a/selfdrive/ui/qt/widgets/keyboard.cc
+++ b/selfdrive/ui/qt/widgets/keyboard.cc
@@ -17,14 +17,14 @@ KeyboardLayout::KeyboardLayout(QWidget *parent, std::vector<QVector<QString>> la
   QObject::connect(btn_group, SIGNAL(buttonClicked(QAbstractButton*)), parent, SLOT(handleButton(QAbstractButton*)));
 
   int i = 0;
-  for (auto s : layout) {
+  for (const auto &s : layout) {
     QHBoxLayout *hlayout = new QHBoxLayout;
 
     if (i == 1) {
       hlayout->addSpacing(90);
     }
 
-    for (QString p : s) {
+    for (const QString &p : s) {
       QPushButton* btn = new QPushButton(p);
       btn->setFixedHeight(120);
       btn_group->addButton(btn);