From 4411f90df058420ecef78d57b98d7ef92d67ab8d Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Sat, 6 Nov 2021 06:07:44 +0800
Subject: [PATCH] driving.cc: const reference the return value of
 get_best_prediction (#22797)

old-commit-hash: fe22a3563c300e8c10b70a67dfa7c1a0393d0421
---
 selfdrive/modeld/models/driving.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/selfdrive/modeld/models/driving.cc b/selfdrive/modeld/models/driving.cc
index 2be6e75fb6..a2ff9e811f 100644
--- a/selfdrive/modeld/models/driving.cc
+++ b/selfdrive/modeld/models/driving.cc
@@ -99,7 +99,7 @@ void fill_sigmoid(const float *input, float *output, int len, int stride) {
 
 void fill_lead(cereal::ModelDataV2::LeadDataV3::Builder lead, const ModelDataRawLeads &leads, int t_idx, float prob_t) {
   std::array<float, LEAD_TRAJ_LEN> lead_t = {0.0, 2.0, 4.0, 6.0, 8.0, 10.0};
-  auto best_prediction = leads.get_best_prediction(t_idx);
+  const auto &best_prediction = leads.get_best_prediction(t_idx);
   lead.setProb(sigmoid(leads.prob[t_idx]));
   lead.setProbTime(prob_t);
   std::array<float, LEAD_TRAJ_LEN> lead_x, lead_y, lead_v, lead_a;
@@ -288,7 +288,7 @@ void fill_road_edges(cereal::ModelDataV2::Builder &framed, const std::array<floa
 }
 
 void fill_model(cereal::ModelDataV2::Builder &framed, const ModelDataRaw &net_outputs) {
-  auto best_plan = net_outputs.plans->get_best_prediction();
+  const auto &best_plan = net_outputs.plans->get_best_prediction();
   std::array<float, TRAJECTORY_SIZE> plan_t;
   std::fill_n(plan_t.data(), plan_t.size(), NAN);
   plan_t[0] = 0.0;