diff --git a/selfdrive/car/tests/routes.py b/selfdrive/car/tests/routes.py index 6b3d6ffe66..a3daaec118 100644 --- a/selfdrive/car/tests/routes.py +++ b/selfdrive/car/tests/routes.py @@ -23,7 +23,7 @@ non_tested_cars = [ HYUNDAI.KIA_OPTIMA_H, ] -TestRoute = namedtuple('TestRoute', ['route', 'car_fingerprint']) +TestRoute = namedtuple('TestRoute', ['route', 'car_fingerprint', 'segment'], defaults=(None,)) routes = [ TestRoute("d6ac8ebdb47bc549|2022-03-31--13-10-06", COMMA.BODY), diff --git a/selfdrive/car/tests/test_models.py b/selfdrive/car/tests/test_models.py index d885693bdf..8cf997a649 100755 --- a/selfdrive/car/tests/test_models.py +++ b/selfdrive/car/tests/test_models.py @@ -16,7 +16,7 @@ from selfdrive.car.gm.values import CAR as GM from selfdrive.car.honda.values import CAR as HONDA, HONDA_BOSCH from selfdrive.car.hyundai.values import CAR as HYUNDAI from selfdrive.car.toyota.values import CAR as TOYOTA -from selfdrive.car.tests.routes import routes, non_tested_cars +from selfdrive.car.tests.routes import non_tested_cars, routes, TestRoute from selfdrive.test.openpilotci import get_url from tools.lib.logreader import LogReader @@ -36,9 +36,9 @@ ignore_addr_checks_valid = [ # build list of test cases routes_by_car = defaultdict(set) for r in routes: - routes_by_car[r.car_fingerprint].add(r.route) + routes_by_car[r.car_fingerprint].add(r) -test_cases: List[Tuple[str, Optional[str]]] = [] +test_cases: List[Tuple[str, Optional[TestRoute]]] = [] for i, c in enumerate(sorted(all_known_cars())): if i % NUM_JOBS == JOB_ID: test_cases.extend((c, r) for r in routes_by_car.get(c, (None, ))) @@ -46,22 +46,26 @@ for i, c in enumerate(sorted(all_known_cars())): SKIP_ENV_VAR = "SKIP_LONG_TESTS" -@parameterized_class(('car_model', 'route'), test_cases) +@parameterized_class(('car_model', 'test_route'), test_cases) class TestCarModel(unittest.TestCase): @unittest.skipIf(SKIP_ENV_VAR in os.environ, f"Long running test skipped. Unset {SKIP_ENV_VAR} to run") @classmethod def setUpClass(cls): - if cls.route is None: + if cls.test_route is None: if cls.car_model in non_tested_cars: print(f"Skipping tests for {cls.car_model}: missing route") raise unittest.SkipTest raise Exception(f"missing test route for {cls.car_model}") disable_radar = False - for seg in (2, 1, 0): + test_segs = (2, 1, 0) + if cls.test_route.segment is not None: + test_segs = (cls.test_route.segment,) + + for seg in test_segs: try: - lr = LogReader(get_url(cls.route, seg)) + lr = LogReader(get_url(cls.test_route.route, seg)) except Exception: continue @@ -80,7 +84,7 @@ class TestCarModel(unittest.TestCase): if len(can_msgs) > int(50 / DT_CTRL): break else: - raise Exception(f"Route {repr(cls.route)} not found or no CAN msgs found. Is it uploaded?") + raise Exception(f"Route: {repr(cls.test_route.route)} with segments: {test_segs} not found or no CAN msgs found. Is it uploaded?") cls.can_msgs = sorted(can_msgs, key=lambda msg: msg.logMonoTime)