From 4625098a7953308cc76c6c9b81d28e6bb89f671c Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Wed, 18 Aug 2021 16:56:37 +0800 Subject: [PATCH] enclose macro arguments in parentheses (#21947) * macro argument should be enclosed in parentheses * CL_CHECK --- selfdrive/common/clutil.h | 2 +- selfdrive/loggerd/omx_encoder.cc | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/selfdrive/common/clutil.h b/selfdrive/common/clutil.h index 4c8723d64d..ffddafadbb 100644 --- a/selfdrive/common/clutil.h +++ b/selfdrive/common/clutil.h @@ -11,7 +11,7 @@ #define CL_CHECK(_expr) \ do { \ - assert(CL_SUCCESS == _expr); \ + assert(CL_SUCCESS == (_expr)); \ } while (0) #define CL_CHECK_ERR(_expr) \ diff --git a/selfdrive/loggerd/omx_encoder.cc b/selfdrive/loggerd/omx_encoder.cc index 59c18c16be..e1fbba64a6 100644 --- a/selfdrive/loggerd/omx_encoder.cc +++ b/selfdrive/loggerd/omx_encoder.cc @@ -21,9 +21,9 @@ #include "selfdrive/loggerd/include/msm_media_info.h" // Check the OMX error code and assert if an error occurred. -#define OMX_CHECK(_expr) \ - do { \ - assert(OMX_ErrorNone == _expr); \ +#define OMX_CHECK(_expr) \ + do { \ + assert(OMX_ErrorNone == (_expr)); \ } while (0) extern ExitHandler do_exit;