From 477e4253f68c01be0777dddfe1fa606b3657d2a9 Mon Sep 17 00:00:00 2001
From: Shane Smiskol <shane@smiskol.com>
Date: Wed, 28 Feb 2024 20:01:58 -0600
Subject: [PATCH] GM: add more FW logging (#31633)

* add more DIDs

* one more

* update refs

* rm

* btr

* Update selfdrive/car/gm/values.py
old-commit-hash: ec9856b784e6cda8f02e012076666aebe7476650
---
 selfdrive/car/gm/values.py                 | 13 +++++++++++++
 selfdrive/car/tests/test_fw_fingerprint.py |  4 ++--
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/selfdrive/car/gm/values.py b/selfdrive/car/gm/values.py
index 35fdf3fb92..ca35b53f72 100644
--- a/selfdrive/car/gm/values.py
+++ b/selfdrive/car/gm/values.py
@@ -189,22 +189,35 @@ class CanBus:
 # In a Data Module, an identifier is a string used to recognize an object,
 # either by itself or together with the identifiers of parent objects.
 # Each returns a 4 byte hex representation of the decimal part number. `b"\x02\x8c\xf0'"` -> 42790951
+GM_BOOT_SOFTWARE_PART_NUMER_REQUEST = b'\x1a\xc0'  # likely does not contain anything useful
 GM_SOFTWARE_MODULE_1_REQUEST = b'\x1a\xc1'
 GM_SOFTWARE_MODULE_2_REQUEST = b'\x1a\xc2'
 GM_SOFTWARE_MODULE_3_REQUEST = b'\x1a\xc3'
+
+# Part number of XML data file that is used to configure ECU
+GM_XML_DATA_FILE_PART_NUMBER = b'\x1a\x9c'
+GM_XML_CONFIG_COMPAT_ID = b'\x1a\x9b'  # used to know if XML file is compatible with the ECU software/hardware
+
 # This DID is for identifying the part number that reflects the mix of hardware,
 # software, and calibrations in the ECU when it first arrives at the vehicle assembly plant.
 # If there's an Alpha Code, it's associated with this part number and stored in the DID $DB.
 GM_END_MODEL_PART_NUMBER_REQUEST = b'\x1a\xcb'
+GM_END_MODEL_PART_NUMBER_ALPHA_CODE_REQUEST = b'\x1a\xdb'
 GM_BASE_MODEL_PART_NUMBER_REQUEST = b'\x1a\xcc'
+GM_BASE_MODEL_PART_NUMBER_ALPHA_CODE_REQUEST = b'\x1a\xdc'
 GM_FW_RESPONSE = b'\x5a'
 
 GM_FW_REQUESTS = [
+  GM_BOOT_SOFTWARE_PART_NUMER_REQUEST,
   GM_SOFTWARE_MODULE_1_REQUEST,
   GM_SOFTWARE_MODULE_2_REQUEST,
   GM_SOFTWARE_MODULE_3_REQUEST,
+  GM_XML_DATA_FILE_PART_NUMBER,
+  GM_XML_CONFIG_COMPAT_ID,
   GM_END_MODEL_PART_NUMBER_REQUEST,
+  GM_END_MODEL_PART_NUMBER_ALPHA_CODE_REQUEST,
   GM_BASE_MODEL_PART_NUMBER_REQUEST,
+  GM_BASE_MODEL_PART_NUMBER_ALPHA_CODE_REQUEST,
 ]
 
 GM_RX_OFFSET = 0x400
diff --git a/selfdrive/car/tests/test_fw_fingerprint.py b/selfdrive/car/tests/test_fw_fingerprint.py
index 88c7225f22..a8bae29391 100755
--- a/selfdrive/car/tests/test_fw_fingerprint.py
+++ b/selfdrive/car/tests/test_fw_fingerprint.py
@@ -263,10 +263,10 @@ class TestFwFingerprintTiming(unittest.TestCase):
         print(f'get_vin {name} case, query time={self.total_time / self.N} seconds')
 
   def test_fw_query_timing(self):
-    total_ref_time = {1: 7.8, 2: 8.7}
+    total_ref_time = {1: 8.3, 2: 9.2}
     brand_ref_times = {
       1: {
-        'gm': 0.5,
+        'gm': 1.0,
         'body': 0.1,
         'chrysler': 0.3,
         'ford': 1.5,