From 4974ca03a8ec1919075cd41da0a80eb1f32f53dd Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Fri, 9 Sep 2022 07:46:52 +0800
Subject: [PATCH] ui: stop timer if PairingQRWidget is hidden (#25671)

---
 selfdrive/ui/qt/widgets/prime.cc | 16 +++++++++-------
 selfdrive/ui/qt/widgets/prime.h  |  2 ++
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/selfdrive/ui/qt/widgets/prime.cc b/selfdrive/ui/qt/widgets/prime.cc
index 5419475262..a8ceee4ca9 100644
--- a/selfdrive/ui/qt/widgets/prime.cc
+++ b/selfdrive/ui/qt/widgets/prime.cc
@@ -18,21 +18,23 @@
 using qrcodegen::QrCode;
 
 PairingQRWidget::PairingQRWidget(QWidget* parent) : QWidget(parent) {
-  QTimer* timer = new QTimer(this);
-  timer->start(5 * 60 * 1000);
+  timer = new QTimer(this);
   connect(timer, &QTimer::timeout, this, &PairingQRWidget::refresh);
 }
 
 void PairingQRWidget::showEvent(QShowEvent *event) {
   refresh();
+  timer->start(5 * 60 * 1000);
+}
+
+void PairingQRWidget::hideEvent(QHideEvent *event) {
+  timer->stop();
 }
 
 void PairingQRWidget::refresh() {
-  if (isVisible()) {
-    QString pairToken = CommaApi::create_jwt({{"pair", true}});
-    QString qrString = "https://connect.comma.ai/?pair=" + pairToken;
-    this->updateQrCode(qrString);
-  }
+  QString pairToken = CommaApi::create_jwt({{"pair", true}});
+  QString qrString = "https://connect.comma.ai/?pair=" + pairToken;
+  this->updateQrCode(qrString);
 }
 
 void PairingQRWidget::updateQrCode(const QString &text) {
diff --git a/selfdrive/ui/qt/widgets/prime.h b/selfdrive/ui/qt/widgets/prime.h
index ce4baecfa2..0a1d93250d 100644
--- a/selfdrive/ui/qt/widgets/prime.h
+++ b/selfdrive/ui/qt/widgets/prime.h
@@ -25,8 +25,10 @@ public:
 
 private:
   QPixmap img;
+  QTimer *timer;
   void updateQrCode(const QString &text);
   void showEvent(QShowEvent *event) override;
+  void hideEvent(QHideEvent *event) override;
 
 private slots:
   void refresh();