From 4a74d777f09b606abdde141c456cd73281d20947 Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Wed, 9 Jun 2021 04:32:10 +0800 Subject: [PATCH] Properly set parent for widgets (#21196) --- selfdrive/ui/qt/offroad/wifiManager.cc | 2 +- selfdrive/ui/qt/setup/setup.cc | 2 +- selfdrive/ui/qt/setup/wifi.cc | 2 +- selfdrive/ui/qt/spinner.cc | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/selfdrive/ui/qt/offroad/wifiManager.cc b/selfdrive/ui/qt/offroad/wifiManager.cc index 1e2cccb507..9f2b05fad0 100644 --- a/selfdrive/ui/qt/offroad/wifiManager.cc +++ b/selfdrive/ui/qt/offroad/wifiManager.cc @@ -64,7 +64,7 @@ bool compare_by_strength(const Network &a, const Network &b) { return a.strength > b.strength; } -WifiManager::WifiManager(QWidget* parent) { +WifiManager::WifiManager(QWidget* parent) : QWidget(parent) { qDBusRegisterMetaType(); qDBusRegisterMetaType(); connecting_to_network = ""; diff --git a/selfdrive/ui/qt/setup/setup.cc b/selfdrive/ui/qt/setup/setup.cc index 1c6fbdef0f..d2ed683521 100644 --- a/selfdrive/ui/qt/setup/setup.cc +++ b/selfdrive/ui/qt/setup/setup.cc @@ -171,7 +171,7 @@ void Setup::nextPage() { setCurrentIndex(currentIndex() + 1); } -Setup::Setup(QWidget *parent) { +Setup::Setup(QWidget *parent) : QStackedWidget(parent) { addWidget(getting_started()); addWidget(network_setup()); addWidget(software_selection()); diff --git a/selfdrive/ui/qt/setup/wifi.cc b/selfdrive/ui/qt/setup/wifi.cc index be32bdc073..b46658c651 100644 --- a/selfdrive/ui/qt/setup/wifi.cc +++ b/selfdrive/ui/qt/setup/wifi.cc @@ -16,7 +16,7 @@ void WifiSetup::finish() { qApp->exit(); } -WifiSetup::WifiSetup(QWidget *parent) { +WifiSetup::WifiSetup(QWidget *parent) : QWidget(parent) { QHBoxLayout *main_layout = new QHBoxLayout(); QPushButton *finish_btn = new QPushButton("Exit"); diff --git a/selfdrive/ui/qt/spinner.cc b/selfdrive/ui/qt/spinner.cc index 79a4f1049d..305dda1de3 100644 --- a/selfdrive/ui/qt/spinner.cc +++ b/selfdrive/ui/qt/spinner.cc @@ -52,7 +52,7 @@ void TrackWidget::paintEvent(QPaintEvent *event) { // Spinner -Spinner::Spinner(QWidget *parent) { +Spinner::Spinner(QWidget *parent) : QWidget(parent) { QGridLayout *main_layout = new QGridLayout(); main_layout->setSpacing(0); main_layout->setMargin(200);