From 4acc82604d456dc5280e62f946f3fdd1e0ce5810 Mon Sep 17 00:00:00 2001 From: Adeeb Shihadeh Date: Sat, 19 Sep 2020 12:53:36 -0700 Subject: [PATCH] quick lgtm fixes --- selfdrive/debug/cycle_alerts.py | 1 - selfdrive/ui/qt/settings.cc | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/selfdrive/debug/cycle_alerts.py b/selfdrive/debug/cycle_alerts.py index f73b4b54cc..45bc8984c2 100755 --- a/selfdrive/debug/cycle_alerts.py +++ b/selfdrive/debug/cycle_alerts.py @@ -23,7 +23,6 @@ def cycle_alerts(duration=200, is_metric=False): thermal = messaging.pub_sock('thermal') idx, last_alert_millis = 0, 0 - alert = alerts[0] events = Events() AM = AlertManager() diff --git a/selfdrive/ui/qt/settings.cc b/selfdrive/ui/qt/settings.cc index 3da1934bc7..562a7f19b6 100644 --- a/selfdrive/ui/qt/settings.cc +++ b/selfdrive/ui/qt/settings.cc @@ -17,13 +17,13 @@ #include "common/params.h" -ParamsToggle::ParamsToggle(QString param, QString title, QString description, QString icon, QWidget *parent): QFrame(parent) , param(param) { +ParamsToggle::ParamsToggle(QString param, QString title, QString description, QString icon_path, QWidget *parent): QFrame(parent) , param(param) { QHBoxLayout *hlayout = new QHBoxLayout; QVBoxLayout *vlayout = new QVBoxLayout; hlayout->addSpacing(25); - if (icon.length()){ - QPixmap pix(icon); + if (icon_path.length()){ + QPixmap pix(icon_path); QLabel *icon = new QLabel(); icon->setPixmap(pix.scaledToWidth(100, Qt::SmoothTransformation)); icon->setSizePolicy(QSizePolicy(QSizePolicy::Fixed, QSizePolicy::Fixed));