From 4bb578ff1bc67640d2cd9828de51ed8269c17273 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Tue, 21 Jan 2025 17:29:56 -0800 Subject: [PATCH] Fix duplicate process names (#34446) * test * anything actually use this? * keep it around --- system/manager/process_config.py | 2 +- system/manager/test/test_manager.py | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/system/manager/process_config.py b/system/manager/process_config.py index 004180c9b5..b9655c83f3 100644 --- a/system/manager/process_config.py +++ b/system/manager/process_config.py @@ -82,7 +82,7 @@ procs = [ NativeProcess("ui", "selfdrive/ui", ["./ui"], always_run, watchdog_max_dt=(5 if not PC else None)), PythonProcess("soundd", "selfdrive.ui.soundd", only_onroad), PythonProcess("locationd", "selfdrive.locationd.locationd", only_onroad), - NativeProcess("pandad", "selfdrive/pandad", ["./pandad"], always_run, enabled=False), + NativeProcess("_pandad", "selfdrive/pandad", ["./pandad"], always_run, enabled=False), PythonProcess("calibrationd", "selfdrive.locationd.calibrationd", only_onroad), PythonProcess("torqued", "selfdrive.locationd.torqued", only_onroad), PythonProcess("controlsd", "selfdrive.controls.controlsd", and_(not_joystick, iscar)), diff --git a/system/manager/test/test_manager.py b/system/manager/test/test_manager.py index b6f47fb75f..9c0b664006 100644 --- a/system/manager/test/test_manager.py +++ b/system/manager/test/test_manager.py @@ -7,7 +7,7 @@ from cereal import car from openpilot.common.params import Params import openpilot.system.manager.manager as manager from openpilot.system.manager.process import ensure_running -from openpilot.system.manager.process_config import managed_processes +from openpilot.system.manager.process_config import managed_processes, procs from openpilot.system.hardware import HARDWARE os.environ['FAKEUPLOAD'] = "1" @@ -31,6 +31,9 @@ class TestManager: os.environ['PREPAREONLY'] = '1' manager.main() + def test_duplicate_procs(self): + assert len(procs) == len(managed_processes), "Duplicate process names" + def test_blacklisted_procs(self): # TODO: ensure there are blacklisted procs until we have a dedicated test assert len(BLACKLIST_PROCS), "No blacklisted procs to test not_run"