From 4c90bb8635d460c1a574f3ab3d7aa264179c197e Mon Sep 17 00:00:00 2001
From: Dean Lee <deanlee3@gmail.com>
Date: Thu, 3 Nov 2022 01:45:54 +0800
Subject: [PATCH] cabana: optimize chart update (#26327)

optimize update
---
 tools/cabana/chartswidget.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/cabana/chartswidget.cc b/tools/cabana/chartswidget.cc
index 72c9c40570..85284af6fc 100644
--- a/tools/cabana/chartswidget.cc
+++ b/tools/cabana/chartswidget.cc
@@ -325,7 +325,6 @@ void ChartView::updateLineMarker(double current_sec) {
           chart()->plotArea().width() * (current_sec - axis_x->min()) / (axis_x->max() - axis_x->min());
   if (int(line_marker->line().x1()) != x) {
     line_marker->setLine(x, 0, x, height());
-    chart()->update();
   }
 }
 
@@ -410,6 +409,7 @@ void ChartView::mouseReleaseEvent(QMouseEvent *event) {
   } else {
     QGraphicsView::mouseReleaseEvent(event);
   }
+  setViewportUpdateMode(QGraphicsView::MinimalViewportUpdate);
 }
 
 void ChartView::mouseMoveEvent(QMouseEvent *ev) {
@@ -436,6 +436,8 @@ void ChartView::mouseMoveEvent(QMouseEvent *ev) {
     track_line->setVisible(value != vals.end());
     value_text->setVisible(value != vals.end());
     track_ellipse->setVisible(value != vals.end());
+  } else {
+    setViewportUpdateMode(QGraphicsView::FullViewportUpdate);
   }
   QChartView::mouseMoveEvent(ev);
 }