From 4ef941e954198a6ed77b4d1cf9389cd621da6aac Mon Sep 17 00:00:00 2001 From: Dean Lee Date: Mon, 14 Nov 2022 04:56:48 +0800 Subject: [PATCH] Cabana: update detail view on change (#26476) update on changed --- tools/cabana/detailwidget.cc | 7 ++++--- tools/cabana/detailwidget.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/cabana/detailwidget.cc b/tools/cabana/detailwidget.cc index 00145395fd..260c9dfec7 100644 --- a/tools/cabana/detailwidget.cc +++ b/tools/cabana/detailwidget.cc @@ -89,7 +89,7 @@ DetailWidget::DetailWidget(ChartsWidget *charts, QWidget *parent) : charts(chart QObject::connect(binary_view, &BinaryView::resizeSignal, this, &DetailWidget::resizeSignal); QObject::connect(binary_view, &BinaryView::addSignal, this, &DetailWidget::addSignal); - QObject::connect(can, &CANMessages::updated, this, &DetailWidget::updateState); + QObject::connect(can, &CANMessages::msgsReceived, this, &DetailWidget::updateState); QObject::connect(dbc(), &DBCManager::DBCFileChanged, [this]() { dbcMsgChanged(); }); QObject::connect(tabbar, &QTabBar::customContextMenuRequested, this, &DetailWidget::showTabBarContextMenu); QObject::connect(tabbar, &QTabBar::currentChanged, [this](int index) { @@ -179,9 +179,10 @@ void DetailWidget::dbcMsgChanged(int show_form_idx) { QTimer::singleShot(1, [this]() { setUpdatesEnabled(true); }); } -void DetailWidget::updateState() { +void DetailWidget::updateState(const QHash * msgs) { time_label->setText(QString::number(can->currentSec(), 'f', 3)); - if (msg_id.isEmpty()) return; + if (!msgs->contains(msg_id)) + return; binary_view->updateState(); history_log->updateState(); diff --git a/tools/cabana/detailwidget.h b/tools/cabana/detailwidget.h index 815afa9bce..5fc6d122fe 100644 --- a/tools/cabana/detailwidget.h +++ b/tools/cabana/detailwidget.h @@ -36,7 +36,7 @@ private: void removeSignal(const Signal *sig); void editMsg(); void removeMsg(); - void updateState(); + void updateState(const QHash * msgs); QString msg_id; QLabel *name_label, *time_label, *warning_label;